New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more targeted workaround for Windows Command bug #162

Closed

dherman opened this issue Jan 5, 2017 · 1 comment

Collaborator

dherman commented Jan 5, 2017

PR #159 applies a blunt fix by passing --silent to npm install. We should make it more targeted in a few ways:

Do it only for cfg(windows).
Verify that --loglevel error works and use that instead.
Once std: Don't pass overlapped handles to processes rust-lang/rust#38835 merges in Rust nightly, verify that it works and then use something like rustc_version in the build.rs to decide dynamically based on the Rust version whether it's no longer necessary to use the workaround.

The text was updated successfully, but these errors were encountered:

Member

kjvalencik commented Sep 15, 2021

No longer relevant for Node-API backend.

kjvalencik closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment