From aaa62c4c1014d723d5d10c103c56f05ca035bb9e Mon Sep 17 00:00:00 2001 From: "K.J. Valencik" Date: Wed, 9 Dec 2020 11:37:58 -0500 Subject: [PATCH] review(neon-sys): Fix comments on try_catch --- crates/neon-sys/native/src/neon.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/crates/neon-sys/native/src/neon.h b/crates/neon-sys/native/src/neon.h index 32267d8c6..de4ec62bc 100644 --- a/crates/neon-sys/native/src/neon.h +++ b/crates/neon-sys/native/src/neon.h @@ -148,14 +148,16 @@ extern "C" { void Neon_EventHandler_Schedule(void* thread_safe_cb, void* rust_callback, Neon_EventHandler handler); void Neon_EventHandler_Delete(void* thread_safe_cb); - // The `result` out-parameter can be assumed to be initialized if and only if this function + // The `ok` out-parameter can be assumed to be initialized if and only if this function // returns `CONTROL_RETURNED`. // The `unwind_value` out-parameter can be assumed to be initialized if and only if this // function returns `CONTROL_PANICKED`. typedef try_catch_control_t (*Neon_TryCatchGlue)(void *rust_thunk, void *cx, void *ok, void **unwind_value); - // The `result` out-parameter can be assumed to be initialized if and only if this function - // returns `CONTROL_RETURNED` or `CONTROL_THREW`. + // The `ok` out-parameter can be assumed to be initialized if and only if this function + // returns `CONTROL_RETURNED`. + // The `err` out-parameter can be assumed to be initialized if and only if this function + // returns `CONTROL_THREW`. // The `unwind_value` out-parameter can be assumed to be initialized if and only if this // function returns `CONTROL_PANICKED`. try_catch_control_t Neon_TryCatch_With(Neon_TryCatchGlue glue, void *rust_thunk, void *cx, void *ok, v8::Local *err, void **unwind_value);