Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

optional ABI override in neon build #28

Closed
dherman opened this issue Apr 15, 2016 · 4 comments
Closed

optional ABI override in neon build #28

dherman opened this issue Apr 15, 2016 · 4 comments

Comments

@dherman
Copy link
Collaborator

dherman commented Apr 15, 2016

Currently neon build automatically sets the Node ABI version number by extracting it from process.versions.modules. It should be possible to pass an optional ABI version like neon build --abi=43 to support "cross-compiling" to different Node versions.

@shawedwa
Copy link

shawedwa commented Sep 5, 2016

This makes it difficult to build Rust modules for Electron, since the ABI is typically different for Electron and one's own Node install.

@shawedwa
Copy link

shawedwa commented Sep 5, 2016

It might be nice if it could pull the right version from the included node headers - NODE_MODULE_VERSION is defined in node_version.h.

PR: neon-bindings/neon#109

Edit: Will need to make a corresponding change to neon-cli to not pass in ABI version (unless explicitly overridden) .

@EdShaw
Copy link
Contributor

EdShaw commented Oct 15, 2016

And the corresponding change in neon-cli which actually resolves this issue:
#31

@dherman
Copy link
Collaborator Author

dherman commented Jan 9, 2017

OK I'm closing this one, because as @EdShaw pointed out it's not safe to compile to a different ABI than the headers you're compiling with.

@dherman dherman closed this as completed Jan 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants