Rename doesn't keep attribute name in object

[gavrilyak]

function f(a, b) {
  return { a, b };
}

When renaming a to c in vim the result is:

function f(c, b) {
  return { c, b };
}

The same renaming in VSCode behaves correctly, the result is:

function f(c, b) {
  return { a: c, b };
}

[chemzqm]

Need tsserver log.

[gavrilyak]

tsserver.log

Probably this is just new feature in VSCode.
Proper rename was introduced as new feature in 1.30, and later Microsoft added an option to revert to old behavior. More info here

[gavrilyak]

I added providePrefixAndSuffixTextForRename: true in configure request and server response changed.
It now has "prefixText": "a: " but looks like vim ignores it.

Configure

    "preferences": {
        "disableSuggestions": false,
        "importModuleSpecifierPreference": "non-relative",
        "quotePreference": "single",
        "allowRenameOfImportPath": true,
        "providePrefixAndSuffixTextForRename": true,
        "allowTextChangesInNewFiles": true
    }
}

Response from rename is

Result: {
    "info": {
        "canRename": true,
        "displayName": "a",
        "fullDisplayName": "a",
        "kind": "parameter",
        "kindModifiers": "",
        "triggerSpan": {
            "start": {
                "line": 1,
                "offset": 12
            },
            "end": {
                "line": 1,
                "offset": 13
            }
        }
    },
    "locs": [
        {
            "file": "/home/gvv/code/play/rename/rename.js",
            "locs": [
                {
                    "start": {
                        "line": 1,
                        "offset": 12
                    },
                    "end": {
                        "line": 1,
                        "offset": 13
                    }
                },
                {
                    "start": {
                        "line": 2,
                        "offset": 12
                    },
                    "end": {
                        "line": 2,
                        "offset": 13
                    },
                    "prefixText": "a: "
                }
            ]
        }
    ]
}

[gavrilyak]

And the fix is

                  changes[uri].push({
                    range: typeConverters.Range.fromTextSpan(textSpan),
-                    newText:  newName
-                    newText:  (textSpan.prefixText || '') + newName + (textSpan.suffixText || '')
                  });

Sorry for not providing proper pull request, npm install is failing on typescript compilation on my computer, just hacking coc-tsserver/lib/index.js.

VSCode reference