Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not equal values for duration in expectation #765

Closed
angrykoala opened this issue Jan 10, 2022 · 0 comments · Fixed by #774
Closed

Not equal values for duration in expectation #765

angrykoala opened this issue Jan 10, 2022 · 0 comments · Fixed by #774

Comments

@angrykoala
Copy link
Member

Some integration tests fail unreliably in a Duration comparison:

The following is a Jest summary of one of these errors.

Summary of all failing tests
FAIL packages/graphql/tests/integration/types/duration.int.test.ts
● Duration › create › should create a movie (with a Duration)
expect(received).toStrictEqual(expected) // deep equality
- Expected - 2
+ Received + 2
Object {
"days": 28,
"months": -39,
- "nanoseconds": 1000000000,
- "seconds": 2044106,
+ "nanoseconds": 0,
+ "seconds": 2044107,
}

86 | expect(graphqlMovie.id).toBe(id);
> 87 | expect(parseDuration(graphqlMovie.duration)).toStrictEqual(parsedDuration);
| ^
88 |
89 | const neo4jResult = await session.run(

It is unknown how many tests may be flaky with this issue, but all tests using parseDuration should be checked

@darrellwarde darrellwarde linked a pull request Jan 11, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant