Policy filter GetRelayResult message #543

vncoelho · 2019-01-12T17:31:59Z

No description provided.

vncoelho · 2019-01-12T18:09:02Z

Thanks, broda! 👍

erikzhang · 2019-01-13T06:06:49Z

neo/Ledger/RelayResultReason.cs

-        Invalid,
-        PolicyFail,
-        Unknown
+        Succeed = 0x00,


Do we really need explicit enumeration values?

Perhaps the idea was to avoid changing the value of Unknown again, since Unknown was changed to PolicyFail. Maybe only needs to be explicit for unknown.

I think explicit values make it easier for documentation purposes, otherwise the developer will need to count one by one just to know the expected value xD Regarding Unknown, it's good to have it fixed, even with future changes. If you prefer other numbers, we can change too.

For documentation, we can just use the enumeration names, such as Succeed, AlreadyExists, etc.
The enumeration values are not used anywhere. Even RpcServer is using enumeration names.

I'll rethink this, because I'm probably very wrong then :)

Ok, now I got your point Erik, I'm actually wrong. But still, perhaps a better idea is to automate the Rpc result numbers using -500 + enum value. So, as soon as we add more, it will get automatically documented. Do you think that's reasonable? Otherwise, we can just remove my commit.

Sounds reasonable, brother.

I think I took for granted that they were not actually exposed outside anywhere. Nice it wasn’t needed.

I tried to integrate with actual return values (-500 - enum_Value), but it was a bad idea... too complex because of the subtraction, it would get more complicated, what is not good. Sorry for the misunderstanding.

igormcoelho · 2019-01-15T15:22:59Z

neo/Network/RPC/RpcServer.cs

@@ -127,6 +127,8 @@ private static JObject GetRelayResult(RelayResultReason reason)
                    throw new RpcException(-503, "The block cannot be validated.");
                case RelayResultReason.Invalid:
                    throw new RpcException(-504, "Block or transaction validation failed.");
+                case RelayResultReason.PolicyFail:
+                    throw new RpcException(-505, "One of the Policy filters failed [tx_size_limits_fees or blocked_accounts].");


Let's move forward! In a future we change automatic numbering if necessary.. for now -500, -501 is very clear, which is good. Perhaps it will get worse by putting arithmetic here.

* Handles escape characters in JSON * Pass ApplicationExecution to IPersistencePlugin (neo-project#531) * Update dependencies: (neo-project#532) - Akka 1.3.11 - Microsoft.AspNetCore.ResponseCompression 2.2.0 - Microsoft.AspNetCore.Server.Kestrel 2.2.0 - Microsoft.AspNetCore.Server.Kestrel.Https 2.2.0 - Microsoft.AspNetCore.WebSockets 2.2.0 - Microsoft.EntityFrameworkCore.Sqlite 2.2.0 - Microsoft.Extensions.Configuration.Json 2.2.0 * change version to v2.9.4 * Updating Unknown to Policy Fail (neo-project#533) * Fix a dead lock in `WalletIndexer` * Downgrade Sqlite to 2.1.4 (neo-project#535) * RPC call gettransactionheight (neo-project#541) * getrawtransactionheight Nowadays two calls are need to get a transaction height, `getrawtransaction` with `verbose` and then use the `blockhash`. Other option is to use `confirmations`, but it can be misleading. * Minnor fix * Shargon's tip * modified * Allow to use the wallet inside a RPC plugin (neo-project#536) * Improve Large MemoryPool Performance - Sort + intelligent TX reverification (neo-project#500) Improve Large MemoryPool Performance - Sort + intelligent TX reverification (neo-project#500) * Keep both verified and unverified (previously verified) transactions in sorted trees so ejecting transactions above the pool size is a low latency operation. * Re-verify unverified transactions when Blockchain actor is idle. * Don't re-verify transactions needlessly when not at the tip of the chain. * Support passing a flag to `getrawmempool` to retrieve both verified and unverified TX hashes. * Support MaxTransactionsPerBlock and MaxFreeTransactionsPerBlock from Policy plugins. * Rebroadcast re-verified transactions if it has been a while since last broadcast (high priority transactions are rebroadcast more frequently than low priority transactions. * Policy filter GetRelayResult message (neo-project#543) * Policy filter GetRelayResult message * adding fixed numbering for return codes * Removed enum fixed values * Add some initial MemoryPool unit tests. Fix bug when Persisting the GenesisBlock (neo-project#549) * More MemoryPool Unit Tests. Improve Re-broadcast back-off to an increasing linear formula. (neo-project#554) * Ensuring Object Reference check of SortedSets for speed-up (neo-project#557) * Minor comments update on Mempool class (neo-project#556) * Update MemoryPool Unit Test to add random fees to Mock Transactions (neo-project#558) * Add Unit Test for MemoryPool sort order. Fixed sort order to return descending. (neo-project#559) * Add unit test to verify memory pool sort order and reverification order. Fixed sort order bug. * VerifyCanTransactionFitInPool works as intended. Also inadvertantly verified GetLowestFeeTransaction() works. * Benchmark structure for UInt classes (neo-project#553) * basic benchmark structure for UInt classes * commented code2 from lights for now * updated tests. all seem correct now * Switch to using a benchmark method taking a method delegate to benchmark. * Make pass. * 1 million iterations. * Switch to ulong for the 4th option, and it is still the same speed. * fix test data for 50% equal data * make test pass * neo.UnitTests/UT_UIntBenchmarks.cs * neo.UnitTests/UT_UIntBenchmarks.cs * Base 20 - UInt160 tests * neo.UnitTests/UT_UIntBenchmarks.cs * inlined 160 * complete tests with UInt256 and UInt160 * neo.UnitTests/UT_UIntBenchmarks.cs * Lights division calculation * Treat lower hashes as higher priority. Fix MemoryPool UT for Hash order. (neo-project#563) * Treat lower hashes as higher priority. * Fix MemoryPool UT for Hash order. * Renaming Trasanction in PoolItem for clarity. * Make PoolItem independent and add PoolItem tests (neo-project#562) * make poolitem independent * Merging * Multiply by -1 * Fix other * Fix Tx * Removing -1 extra multiplication * Fix * make PoolItem internal and added test class * Update PoolItem.cs * added comments for PoolItem variables * getting time from TimeProvider to allow testing * basic test * reset time provider * Add Hash comparison * Adding time provider again and equals * Fix arithmetic * Comment on PoolItem * Update PoolItem.cs * protecting tests against TimeProvider changes on fails * reusing setup part * fixed serialization properties * Improve generation of creating mock DateTime values. Implement hash comparison tests. * Adjust comment. * Treat Claim transactions as the highest low priority transactions. (neo-project#565) * Allow persistence plugins to commit as a final step. (neo-project#568) * Allow persistence plugins to commit as a final step. * Plugins commit before core commits, once all plugins have handled initial work OnPersist. * Allow PersistencePlugin to determine whether to crash if commit fails. * Add ShouldThrowExceptionFromCommit method to IPersistencePlugin. * Throw all commit exceptions that should be thrown in an AggregateException. * Add a Plugin type for observing transactions added or removed from the MemoryPool. (neo-project#580) * Correctly handle conversions between JSON objects (neo-project#586) * Fix neo-project/neo-node#297 (neo-project#587) * Replace new JArray with .ToArray (AccountState) (neo-project#581) * Ensure `LocalNode` to be stoped before shutting down the `NeoSystem`

* Policy filter GetRelayResult message * adding fixed numbering for return codes * Removed enum fixed values

* add 2.7.4 add 2.7.4 * minor updates minor updates * add Chinese version add Chinese version

vncoelho and others added 2 commits January 12, 2019 15:31

Policy filter GetRelayResult message

70fb3e1

adding fixed numbering for return codes

0c4ff29

jsolman previously approved these changes Jan 13, 2019

View reviewed changes

erikzhang reviewed Jan 13, 2019

View reviewed changes

Merge branch 'master' into policy-filter-GetRelayResult

27c573e

shargon previously approved these changes Jan 13, 2019

View reviewed changes

Removed enum fixed values

1e92cbe

igormcoelho dismissed stale reviews from shargon and jsolman via 1e92cbe January 15, 2019 15:19

igormcoelho approved these changes Jan 15, 2019

View reviewed changes

vncoelho merged commit ff174f7 into master Jan 15, 2019

vncoelho deleted the policy-filter-GetRelayResult branch January 15, 2019 15:30

txhsl mentioned this pull request Feb 25, 2019

Update from master branch txhsl/neo#2

Merged

rodoufu pushed a commit to rodoufu/neo that referenced this pull request Mar 5, 2019

Policy filter GetRelayResult message (neo-project#543)

5c2b39b

* Policy filter GetRelayResult message * adding fixed numbering for return codes * Removed enum fixed values

Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020

Release exchange 2.7.4 (neo-project#543)

9d04985

* add 2.7.4 add 2.7.4 * minor updates minor updates * add Chinese version add Chinese version

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Policy filter GetRelayResult message #543

Policy filter GetRelayResult message #543

vncoelho commented Jan 12, 2019

vncoelho commented Jan 12, 2019

erikzhang Jan 13, 2019

jsolman Jan 13, 2019

igormcoelho Jan 13, 2019

erikzhang Jan 15, 2019

igormcoelho Jan 15, 2019

igormcoelho Jan 15, 2019

vncoelho Jan 15, 2019

jsolman Jan 15, 2019

igormcoelho Jan 15, 2019 •

edited

Loading

igormcoelho Jan 15, 2019

Policy filter GetRelayResult message #543

Policy filter GetRelayResult message #543

Conversation

vncoelho commented Jan 12, 2019

vncoelho commented Jan 12, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

igormcoelho Jan 15, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

igormcoelho Jan 15, 2019 •

edited

Loading