Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NameService UT #2261

Merged
merged 4 commits into from
Jan 25, 2021
Merged

Add NameService UT #2261

merged 4 commits into from
Jan 25, 2021

Conversation

cloud8little
Copy link
Contributor

No description provided.

@cloud8little
Copy link
Contributor Author

@erikzhang do we allow these data to be stored as IPv4 name service? I do not think they are valid ipv4 address. but currently they are valid values from testing result.

            setRecord_ret = Check_SetRecord(snapshot, domain, RecordType.A, "0.0.256", from, persistingBlock);
            setRecord_ret.Should().BeFalse();

            setRecord_ret = Check_SetRecord(snapshot, domain, RecordType.A, "0.257", from, persistingBlock);
            setRecord_ret.Should().BeFalse();

            setRecord_ret = Check_SetRecord(snapshot, domain, RecordType.A, "257", from, persistingBlock);
            setRecord_ret.Should().BeFalse();

@erikzhang
Copy link
Member

Please check #2262

@shargon shargon mentioned this pull request Jan 25, 2021
@cloud8little
Copy link
Contributor Author

wait for #2262

@erikzhang
Copy link
Member

@cloud8little Merge?

@cloud8little
Copy link
Contributor Author

good to merge

@erikzhang erikzhang merged commit aaba978 into neo-project:master Jan 25, 2021
@cloud8little cloud8little deleted the add_nns_ut branch January 25, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants