-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit the maximum block size to 256 KB #359
Comments
How did you decide on 256KB? |
Is there currently a limit? How do you pick which tx's to drop (based on the priority sorting order) or random? |
There is currently no limit. |
To help with the discussion @erikzhang, @decentralisedkev, I looked at 287 thousand blocks in recent history (June-Aug 2018). Of them, there is only 15 above 256KB (262144 bytes). That's less than 0.0052% of blocks. |
And it's 257 above 128KB (131,072 bytes), that's 0.089% for the same dataset. |
Good data and precise studies. |
I added a comment on the end of issue #357 concerning a potential solution to throttle bad actors for which I've started drafting a NEP. |
@erikzhang, do you still believe that this is necessary? Maybe with the correct Economic model and the refined verification+application layers we are not going to need to have this limit. However, since blocks can be faster this can also be a good practice for the P2P decentralization. |
I think we can set the maximum block size in |
Ok, @erikzhang, so, still proceed with this idea, right? @shargon, @igormcoelho, @jsolman, limit or not limit, this is the question...aheuahuea |
We must implement the max, is totally needed. |
In order to prevent the block data from growing too fast, it is necessary to limit the maximum size of each block.
The text was updated successfully, but these errors were encountered: