Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient TestModeGas for register candidate #2260

Closed
superboyiii opened this issue Jan 24, 2021 · 3 comments · Fixed by neo-project/neo-node#727
Closed

Insufficient TestModeGas for register candidate #2260

superboyiii opened this issue Jan 24, 2021 · 3 comments · Fixed by neo-project/neo-node#727

Comments

@superboyiii
Copy link
Member

Describe the bug
Insufficient TestModeGas for register candidate

How much should we choose now? 20 is not enough for register(need 1000), but we'd like to prevent malicious attack. May be we could make it into settings file? Make it default as 20 but people are able to change it and use at their own risk.

@shargon @erikzhang

@roman-khimov
Copy link
Contributor

We had a similar problem and decided to leave the default as is (15 for neo-go), when creating registration transaction we just add an appropriate amount of GAS without test-invoking via RPC.

@superboyiii
Copy link
Member Author

We had a similar problem and decided to leave the default as is (15 for neo-go), when creating registration transaction we just add an appropriate amount of GAS without test-invoking via RPC.

I think we could add a param in config.json of neo-cli and using it in engine.run() like what we're doing in RpcServer:
using ApplicationEngine engine = ApplicationEngine.Run(script, container: tx, gas: settings.MaxGasInvoke);

@shargon
Copy link
Member

shargon commented Jan 25, 2021

I think that specific tests should have specific gas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants