Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AllowCall call flag to VerifyWitness for native contracts #2142

Closed
AnnaShaleva opened this issue Dec 11, 2020 · 0 comments · Fixed by #2144
Closed

Add AllowCall call flag to VerifyWitness for native contracts #2142

AnnaShaleva opened this issue Dec 11, 2020 · 0 comments · Fixed by #2144

Comments

@AnnaShaleva
Copy link
Member

Describe the bug
#2121 replaced required None call flag by AllowCall flag for Neo.Native.Call syscall. However, the current contract verification scheme assumes that native contract verification script is loaded with ReadStates call flag (see VerifyWitness method). So this change brokes verify method for native contracts because we have ReadStates flag instead of required AllowCall flag.

Expected behavior
No error during native verify method call.

Additional context
The issue may be fixed by adding AllowCall flag to the context callFlags in VerifyWitness method in case if the contract is native.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant