Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

long type can not convert implicitly to int type for dotnet 5.0 #2078

Closed
cloud8little opened this issue Nov 20, 2020 · 1 comment · Fixed by #2083
Closed

long type can not convert implicitly to int type for dotnet 5.0 #2078

cloud8little opened this issue Nov 20, 2020 · 1 comment · Fixed by #2083

Comments

@cloud8little
Copy link
Contributor

Describe the bug
update the framework of neo project to net5.0, and reference neo-vm master branch. Build failed.

To Reproduce
Steps to reproduce the behavior:

  1. Open the neo-cli and neo project, update the framework to net5.0
  2. Build the project.

Expected behavior
Build successfully.

Screenshots
1f687c704dc061673e783c56999ef67

Platform:

  • OS: Windows 10 x64
  • Version master
@superboyiii
Copy link
Member

superboyiii commented Nov 20, 2020 •
edited
Loading

The same too me. Seems .Net 5.0 has BigInterger.GetBitLength() by it's own as a new feature, but it returns long indead. We're using Helper.GetBitLength() in .Net 3.0 and it returns int. But recommand to fix this after release of Preview4 to avoid .net SDK conflict.
image

@erikzhang erikzhang mentioned this issue Nov 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.NET 5.0 neo-project/neo
2 participants
@cloud8little @superboyiii