Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stable connection can make node stop sync (master-2.x, neox-2.x) #1806

Closed
superboyiii opened this issue Jul 30, 2020 · 3 comments
Closed

Stable connection can make node stop sync (master-2.x, neox-2.x) #1806

superboyiii opened this issue Jul 30, 2020 · 3 comments

Comments

@superboyiii
Copy link
Member

superboyiii commented Jul 30, 2020 •
edited
Loading

Describe the bug
In stable network, if the connected peers are always there, peers' height will not often refresh which makes the node can't ask for the latest height and stop sync. Although we have ping pang mechanism, it needs at least one peer disconnected.

To Reproduce
Steps to reproduce the behavior:

  1. Prepare a stable network, docker is better and connect stable peers.
  2. Run a node on testnet (v2.10.3)
  3. Wait for several hours, will reproduce in one day.

Expected behavior
Not sync anymore but restarting node is OK.
@superboyiii superboyiii changed the title Stable connection can make node stop sync Stable connection can make node stop sync (master-2.x, neox-2.x) Jul 30, 2020
@Ashuaidehao Ashuaidehao mentioned this issue Jul 31, 2020
Merged
@shargon
Copy link
Member

shargon commented Aug 4, 2020

Did you tested if it's reproducible in neo3?

@superboyiii
Copy link
Member Author

Did you tested if it's reproducible in neo3?

I can't reproduce it even in neo2, but someone reflect it to me.

@shargon shargon mentioned this issue Aug 6, 2020
Merged
@vncoelho
Copy link
Member

Probably this is related to #2059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shargon @vncoelho @superboyiii