Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

typo, comment #847

Merged
merged 30 commits into from
Mar 31, 2022
Merged

typo, comment #847

merged 30 commits into from
Mar 31, 2022

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Jan 20, 2022

No description provided.

@coveralls
Copy link

coveralls commented Jan 20, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2056047779

  • 1 of 32 (3.13%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 15.08%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Neo.ConsoleService/CommandToken.cs 1 2 50.0%
Neo.ConsoleService/ServiceProxy.cs 0 3 0.0%
Neo.ConsoleService/ConsoleServiceBase.cs 0 27 0.0%
Files with Coverage Reduction New Missed Lines %
Neo.ConsoleService/ConsoleServiceBase.cs 2 0%
Totals Coverage Status
Change from base Build 1810946609: 0.1%
Covered Lines: 107
Relevant Lines: 683
💛 - Coveralls

shargon
shargon suggested changes Jan 20, 2022
View reviewed changes
erikzhang
erikzhang reviewed Jan 26, 2022
View reviewed changes
@Jim8y Jim8y changed the title typo, comment, code optimization. typo, comment Jan 27, 2022
shargon
shargon reviewed Jan 27, 2022
View reviewed changes
Jim8y and others added 2 commits January 27, 2022 09:35
@Jim8y @shargon
Update neo-cli/CLI/MainService.Contracts.cs
7343441 
Co-authored-by: Shargon <shargon@gmail.com>
@Jim8y @shargon
Update neo-cli/CLI/MainService.Contracts.cs
759aa09 
Co-authored-by: Shargon <shargon@gmail.com>
shargon
shargon previously approved these changes Jan 27, 2022
View reviewed changes
erikzhang
erikzhang reviewed Jan 30, 2022
View reviewed changes
neo-cli/CLI/Logger.cs Outdated
Comment on lines 81 to 82
default:
throw new ArgumentOutOfRangeException(nameof(level), level, null);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just ignore it?

@Jim8y Jim8y changed the base branch from master to develop February 8, 2022 19:33
erikzhang
erikzhang reviewed Mar 27, 2022
View reviewed changes
neo-cli/CLI/MainService.Node.cs Outdated
@@ -71,7 +71,7 @@ private void OnShowStateCommand()
NeoSystem.LocalNode.Tell(Message.Create(MessageCommand.Ping, PingPayload.Create(NativeContract.Ledger.CurrentIndex(NeoSystem.StoreView))));
await Task.Delay(NeoSystem.Settings.TimePerBlock, cancel.Token);
}
});
}, cancel.Token);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not necessary. Because it is already judged in the loop.

@shargon shargon merged commit ab5447d into neo-project:develop Mar 31, 2022
@Jim8y Jim8y deleted the code-review branch March 31, 2022 13:24
erikzhang pushed a commit that referenced this pull request Apr 19, 2022
@superboyiii
3.2.1 (#859)
45f42b3 
* neo-cli: tune MaxTransactionsPerBlock for testnet (#850)

* Add new testnet network id (#852)

* typo, comment (#847)

* Install plugin and dependencies. (#807)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shargon shargon shargon approved these changes

@erikzhang erikzhang erikzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jim8y @coveralls @shargon @erikzhang