Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core #881

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Update core #881

merged 4 commits into from
Feb 23, 2024

Conversation

shargon
Copy link
Member

@shargon shargon commented Feb 23, 2024

@shargon shargon marked this pull request as ready for review February 23, 2024 13:43
@shargon shargon requested a review from Jim8y February 23, 2024 13:43
@vncoelho
Copy link
Member

let me test

Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#40 6.697 /opt/neo-modules/src/RpcServer/Utility.cs(38,34): error CS1061: 'NativeContract' does not contain a definition for 'GetContractState' and no accessible extension method 'GetContractState' accepting a first argument of type 'NativeContract' could be found (are you missing a using directive or an assembly reference?) [/opt/neo-modules/src/RpcServer/RpcServer.csproj]

@shargon
Copy link
Member Author

shargon commented Feb 23, 2024

#40 6.697 /opt/neo-modules/src/RpcServer/Utility.cs(38,34): error CS1061: 'NativeContract' does not contain a definition for 'GetContractState' and no accessible extension method 'GetContractState' accepting a first argument of type 'NativeContract' could be found (are you missing a using directive or an assembly reference?) [/opt/neo-modules/src/RpcServer/RpcServer.csproj]

You need to update your submodule, it works in workflow

@vncoelho
Copy link
Member

mine is updated

@shargon
Copy link
Member Author

shargon commented Feb 23, 2024

@vncoelho
Copy link
Member

vncoelho commented Feb 23, 2024

My setup is different @shargon

I am obtaining the last neo locally and replacing the folder entirely

# Now it is submodule deps - Removing the existing directory
RUN rm -r /opt/neo-modules/neo
# Copying the new library into place
RUN cp -r /opt/neoLib /opt/neo-modules/neo
# Getting the git version of the module
RUN cd /opt/neoLib && echo "Current neoLib last commit is: $(git rev-parse HEAD)"
# Getting the git version of the submodule
RUN cd /opt/neo-modules && echo "Current neo-modules last commit is: $(git rev-parse HEAD)"
#37 [33/40] RUN cd /opt/neoLib && echo "Current neoLib last commit is: $(git rev-parse HEAD)"
#37 0.324 Current neoLib last commit is: b467613884ef4196283f9f303897dedb0c3de36d
#37 DONE 0.3s

#38 [34/40] RUN cd /opt/neo-modules && echo "Current neo-modules last commit is: $(git rev-parse HEAD)"
#38 0.352 Current neo-modules last commit is: 8aaeb5e571c513458f3e2bf4ffcda090576002c3

@shargon
Copy link
Member Author

shargon commented Feb 23, 2024

My setup is different @shargon

I am obtaining the last neo locally and replacing the folder entirely

# Now it is submodule deps - Removing the existing directory
RUN rm -r /opt/neo-modules/neo
# Copying the new library into place
RUN cp -r /opt/neoLib /opt/neo-modules/neo
# Getting the git version of the module
RUN cd /opt/neoLib && echo "Current neoLib last commit is: $(git rev-parse HEAD)"
# Getting the git version of the submodule
RUN cd /opt/neo-modules && echo "Current neo-modules last commit is: $(git rev-parse HEAD)"
#37 [33/40] RUN cd /opt/neoLib && echo "Current neoLib last commit is: $(git rev-parse HEAD)"
#37 0.324 Current neoLib last commit is: b467613884ef4196283f9f303897dedb0c3de36d
#37 DONE 0.3s

#38 [34/40] RUN cd /opt/neo-modules && echo "Current neo-modules last commit is: $(git rev-parse HEAD)"
#38 0.352 Current neo-modules last commit is: 8aaeb5e571c513458f3e2bf4ffcda090576002c3

Check that you have this commit in neo 66ef246beb6bdc4b259cf503e345ff695725ebbb
neo-project/neo@66ef246

@vncoelho
Copy link
Member

In fact these two were minutes ago....aehauheauea

@shargon shargon merged commit 2adf02b into master Feb 23, 2024
4 of 5 checks passed
@shargon shargon deleted the core-update branch February 23, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update new submodule
3 participants