Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure max length #845

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Ensure max length #845

merged 4 commits into from
Jan 10, 2024

Conversation

shargon
Copy link
Member

@shargon shargon commented Nov 17, 2023 •
edited
Loading

Related to: #827 (comment)

@shargon
Copy link
Member Author

shargon commented Nov 17, 2023

We can wait for #815

roman-khimov added a commit to nspcc-dev/neo-go that referenced this pull request Nov 20, 2023
@roman-khimov
rpcsrv/params: limit tx signers/witnesses
f6cb698 
Inspired by neo-project/neo-modules#845.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
@roman-khimov roman-khimov mentioned this pull request Nov 20, 2023
Merged
AnnaShaleva
AnnaShaleva reviewed Nov 20, 2023
View reviewed changes
src/RpcServer/RpcServer.SmartContract.cs
@@ -166,6 +166,11 @@ private static JObject ToJson(StackItem item, Session session)

private static Signer[] SignersFromJson(JArray _params, ProtocolSettings settings)
{
if (_params.Count > Transaction.MaxTransactionAttributes)
{
throw new RpcException(-100, "Max allowed witness exceeded.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can wait for #815

Agree, some InvalidParams error can be used here. I'll review #815 one more time ASAP.

@cschuchardt88
Copy link
Member

cschuchardt88 commented Nov 20, 2023 •
edited
Loading

have max allowed witness conditions been fixed in neo-core or here? like and boolean not etc

@shargon
Copy link
Member Author

shargon commented Dec 13, 2023

have max allowed witness conditions been fixed in neo-core or here? like and boolean not etc

Must be on both, here is composed manually, not deserialized.

@Jim8y
Copy link
Contributor

Jim8y commented Dec 13, 2023

@shargon , grand master, can we have a sole project where all limits are set together? the existing limitations are like here and there, hard to follow and track.

@shargon
Copy link
Member Author

shargon commented Dec 14, 2023 •
edited
Loading

@shargon , grand master, can we have a sole project where all limits are set together? the existing limitations are like here and there, hard to follow and track.

Agree, but the limits are during deserialization, and here the object is composed manually, so the nodes are protected, but no the rpc node, I think

@shargon
Copy link
Member Author

shargon commented Jan 10, 2024

I will merge it, #815 is delayed and it can replace this throw later

@shargon shargon merged commit 6a5c7eb into master Jan 10, 2024
2 checks passed
@shargon shargon deleted the check-max branch January 10, 2024 08:15
@AnnaShaleva AnnaShaleva mentioned this pull request Jan 10, 2024
Merged
1 task
Jim8y added a commit to Jim8y/neo-modules that referenced this pull request Jan 10, 2024
@Jim8y
Merge branch 'master' of github.com:neo-project/neo-modules
555ba00 
* 'master' of github.com:neo-project/neo-modules:
  Ensure max length (neo-project#845)
  Update .editorconfig and run code analyze (neo-project#866)
  Added AspNetCore (neo-project#863)
  RcpServer: Fixed CORS and Basic Auth (neo-project#812)
  Fix response from getversion due to WS removal (neo-project#859)
  Local dev setup (neo-project#861)
@roman-khimov roman-khimov mentioned this pull request Feb 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaShaleva AnnaShaleva AnnaShaleva left review comments

@Jim8y Jim8y Jim8y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shargon @cschuchardt88 @Jim8y @AnnaShaleva