Refac statedump #789
Closed
Refac statedump #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…modules into refac-statedump
| string dirPathWithBlock = $"./Storage_{network:x8}/BlockStorage_{folder}"; | ||
| Directory.CreateDirectory(dirPathWithBlock); | ||
| return dirPathWithBlock; | ||
| uint folder = (blockIndex / storagePerFolder) * storagePerFolder; |
There was a problem hiding this comment.
This changes the naming scheme and will break scripts like https://github.com/nspcc-dev/neo-go/blob/master/scripts/compare-dumps/compare-dumps.go. Please keep the old scheme, I doubt changing it is important wrt to this PR goals.
There was a problem hiding this comment.
Sure, I'll make a new simple plugin so you won't change it.
Merged
vncoelho
reviewed
Jan 27, 2023
| @@ -26,10 +26,6 @@ internal class Settings | |||
| /// </summary> | |||
| public uint HeightToBegin { get; } | |||
| /// <summary> | |||
| /// Height to begin real-time syncing and dumping on, consequently, dumping every block into a single files | |||
| /// </summary> | |||
| public int HeightToStartRealTimeSyncing { get; } | |||
There was a problem hiding this comment.
Why did you remove this configuration?
This can be useful when debugging or following the chain on real-time
|
Replaced by #790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #736