Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config.json to root folder #709

Merged
merged 2 commits into from
Apr 24, 2022
Merged

Move config.json to root folder #709

merged 2 commits into from
Apr 24, 2022

Conversation

erikzhang
Copy link
Member

Replace #707

@erikzhang
Copy link
Member Author

@Liaojinghui Please check it.

@Jim8y
Copy link
Contributor

Jim8y commented Apr 24, 2022

Works well on my MacOS.

@Jim8y
Copy link
Contributor

Jim8y commented Apr 24, 2022

Works well on my Windows 11

@erikzhang erikzhang merged commit d111ba2 into develop Apr 24, 2022
@erikzhang erikzhang deleted the config-folder branch April 24, 2022 22:44
@cloud8little
Copy link
Contributor

Works well on my MacOS.

what is the behavior currently?

@Jim8y
Copy link
Contributor

Jim8y commented Apr 25, 2022

@cloud8little now config.json appears under the output directory together with the plugin.dll files

@cloud8little
Copy link
Contributor

@cloud8little now config.json appears under the output directory together with the plugin.dll files

every plugin has a config.json file, are we going to combile them all in one config.json file or put all dll and config file for each plugin under each plugin name folder. such as:
RpcServer/RpcServer.dll
RpcServer/config.json
ApplicationLogs/ApplicationLogs.dll
ApplicationLogs/config.json

@Jim8y
Copy link
Contributor

Jim8y commented Apr 26, 2022

@cloud8little

RpcServer/RpcServer.dll
RpcServer/config.json
ApplicationLogs/ApplicationLogs.dll
ApplicationLogs/config.json

@vncoelho
Copy link
Member

vncoelho commented Jun 7, 2022

I am getting this error now.

  neo -> /opt/neo-modules/neoLib/src/neo/bin/Release/net6.0/Neo.dll
  LevelDBStore -> /opt/neo-modules/src/LevelDBStore/bin/Release/net6.0/LevelDBStore.dll
  RpcServer -> /opt/neo-modules/src/RpcServer/bin/Release/net6.0/RpcServer.dll
  ApplicationLogs -> /opt/neo-modules/src/ApplicationLogs/bin/Release/net6.0/ApplicationLogs.dll
/usr/share/dotnet/sdk/6.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ConflictResolution.targets(112,5): error NETSDK1152: Found multiple publish output files with the same relative path: /opt/neo-modules/src/RpcServer/config.json, /opt/neo-modules/src/ApplicationLogs/config.json. [/opt/neo-modules/src/ApplicationLogs/ApplicationLogs.csproj]
File does not exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants