Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand getversion RPC call output with network's magic number #358

Closed
roman-khimov opened this issue Sep 29, 2020 · 2 comments · Fixed by #363
Closed

Expand getversion RPC call output with network's magic number #358

roman-khimov opened this issue Sep 29, 2020 · 2 comments · Fixed by #363

Comments

@roman-khimov
Copy link
Contributor

Summary or problem description
As all hashes and signatures are network-dependent now all clients need to know the magic number of the network. This magic number can be configured explicitly in the client, but I think we can do a bit better than that by making it discoverable from the server.

Do you have any solution you want to propose?
I don't think it's worth another RPC call, we can just add a magic field to the getversion RPC call return value.

In general, this follows the same line as #355 (and maybe intersects a bit with intentions of neo-project/neo#1977), I'd really like the client to have exactly one thing to configure --- RPC endpoint to use, everything else it needs should be available from that.

Where in the software does this update applies to?

  • RPC (HTTP)
@realloc
Copy link

realloc commented Sep 29, 2020

This feature is needed for NeoFS to work with sidechain. Sharing or hardcoding common privnet magic number may be a security issue.

@shargon
Copy link
Member

shargon commented Sep 29, 2020

Agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants