File Upload In Sandbox Broken

[jonmchan]

The File Upload functionality is broken - it is submitting garbage data in the REQUEST body. Something broke between my branch and getting it into master... I suspect it is all the swagger additions. I did check my branch and it still works, so it isn't the original code. When I have a chance, I will debug this.

[jonmchan]

I finally had a chance to come back to this bug - this is caused by the fix in #453 / #457. The issue is that the data it being sent as multipart/form-data but the headers are overriding Content-type to be application/x-www-form-urlencoded. I agree we shouldn't delete all the custom headers, but the Content-type header definitely needs to be overriden for file upload to work.

[UFOMelkor]

Any news on this? File upload is still broken. #535 fixes this for me but has been closed. If you tell me what was wrong with #535 I would be happy to create a pull request.

[Wirone]

I've spent at least 1 hour on my API developing, testing and vituperating "wtf why my files can't be seen in controller's action?".. Then I checked headers.

First I was thinking it is something about FOSRestBundle, it took me a while to get here. Would be great if it was fixed.

[jonmchan]

I fixed this last year - but I don't know why it wasn't merged. The fix is very trivial - delete passing any Content-type and allow the browser JS engine take care of it. @Wirone , if you'd like it to work now, you can look at my PR #535 .

[ch4r1y]

+1

[AlmogBaku]

Is there any progress on this issue? @willdurand

[hidabe]

What about it? @willdurand

[hidabe]

Fix please... it work:
https://github.com/jonmchan/NelmioApiDocBundle/commit/45f5c91bcfb9da0642e6155e2d1df9041c7863f8

[s1yamuza]

Same problem here...

[brice]

Same problem here

[mremi]

+1 Any news about this please?

[guillermogfer]

I also came across with this issue too...

[willdurand]

Does this fix work?

[willdurand]

ping @mremi @guillermogfer @brice @s1yamuza

[brice]

Works for me.

[mremi]

👍 @willdurand

[mremi]

@willdurand When do you plan to bump a new release? Thx

[willdurand]

@mremi here you go: 2.10.2

[mremi]

Nice!

[UFOMelkor]

Thank you!

[ghanbari]

thank you

[jonmchan]

wow, that took forever. 😄 Glad my PR finally made it in after a whole year!

[guillermogfer]

Nice job ;)