Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove files related to cypress #2337

Closed
Tracked by #1958
dcmcand opened this issue Mar 18, 2024 · 2 comments · Fixed by #2672
Closed
Tracked by #1958

Remove files related to cypress #2337

dcmcand opened this issue Mar 18, 2024 · 2 comments · Fixed by #2672
Assignees
Labels
area: testing ✅ Testing status: in progress 🏗 This task is currently being worked on

Comments

@dcmcand
Copy link
Contributor

dcmcand commented Mar 18, 2024

No description provided.

@marcelovilla
Copy link
Member

See #2075 for progress done in the past regarding the migration of Cypress to Playwright.

@marcelovilla
Copy link
Member

I went over our Cypress tests and they perform the following actions:

  1. Login to Nebari
  2. Run a notebook
  3. Visit different services URLs (i.e., keycloak, conda-store, and grafana); there's no interaction with these, however.

Our Playwright tests already take care of (1) and (2). Regarding (3):

  • We're already implicitly testing keycloak's availability when logging in.
  • We have a test for Grafana which implicitly tests the existence of the service (by accessing the API).
  • We don't have anything that tests conda-store's availability for local tests as far as I am aware. We do have a health check for cloud tests, though.

While #2075 takes care of removing all cypress-related files, it is only migrating (1) to Playwright. I could migrate (3) to Playwright (it's not too much effort) but I don't think it will be beneficial, except from maybe catching conda-store not being available in the local integration tests.

Eventually, I'd like to incorporate different user journeys regarding these services, whether that involves UI testing or not.

Happy to hear your opinions here.

I am including @Adam-D-Lewis in the conversation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment