Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove keycloak-metrics-spi-2.5.3.jar from repo and download it and verify checksum instead #1805

Closed
Adam-D-Lewis opened this issue May 16, 2023 · 1 comment · Fixed by #1810
Closed

Remove keycloak-metrics-spi-2.5.3.jar from repo and download it and verify checksum instead #1805

Adam-D-Lewis opened this issue May 16, 2023 · 1 comment · Fixed by #1810
Assignees
@Adam-D-Lewis

Comments

@Adam-D-Lewis
Copy link
Member

Context

To give more confidence that the keycloak-metrics-spi-2.5.3.jar has not been altered, we should download the jar and verify it's checksum instead. Currently the executable is vendored in the repo and put in a k8s secret.

Value and/or benefit

Improve confidence in project. Reduce risk of modifying jar.

Anything else?

No response
@Adam-D-Lewis Adam-D-Lewis added the needs: triage 🚦 Someone needs to have a look at this issue and triage label May 16, 2023
@Adam-D-Lewis
Copy link
Member Author

Adam-D-Lewis commented May 16, 2023 •
edited
Loading

busyBox image would have the needed utilities

@Adam-D-Lewis Adam-D-Lewis self-assigned this May 17, 2023
@Adam-D-Lewis Adam-D-Lewis mentioned this issue May 17, 2023
Merged
10 tasks
@github-project-automation github-project-automation bot moved this from New 📬 to Done 💪🏾 in 🪴 Nebari Project Management May 18, 2023
@Adam-D-Lewis Adam-D-Lewis removed the needs: triage 🚦 Someone needs to have a look at this issue and triage label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Adam-D-Lewis Adam-D-Lewis

Labels
None yet
Projects
🪴 Nebari Project Management
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unvendor keycloak_metrics_spi nebari-dev/nebari
1 participant
@Adam-D-Lewis