From f4179dcd7c1c370cc9bf9fea8b658a8cc875777b Mon Sep 17 00:00:00 2001 From: eskild <42120229+iameskild@users.noreply.github.com> Date: Fri, 23 Jun 2023 16:05:05 +0200 Subject: [PATCH] =?UTF-8?q?Fix=20edge-case=20where=20k8s=5Fversion=20is=20?= =?UTF-8?q?equal=20to=20HIGHEST=5FSUPPORTED=5FK8S=5FVER=E2=80=A6=20(#1842)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../{publish-from-template.py => render_template.py} | 0 .github/workflows/test-provider.yaml | 2 +- src/_nebari/provider/cloud/commons.py | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) rename .github/actions/publish-from-template/{publish-from-template.py => render_template.py} (100%) diff --git a/.github/actions/publish-from-template/publish-from-template.py b/.github/actions/publish-from-template/render_template.py similarity index 100% rename from .github/actions/publish-from-template/publish-from-template.py rename to .github/actions/publish-from-template/render_template.py diff --git a/.github/workflows/test-provider.yaml b/.github/workflows/test-provider.yaml index d75c071032..9bd764ebb4 100644 --- a/.github/workflows/test-provider.yaml +++ b/.github/workflows/test-provider.yaml @@ -149,4 +149,4 @@ jobs: PROVIDER: ${{ matrix.provider }} CICD: ${{ matrix.cicd }} with: - filename: .github/failed-workflow-issue-templates/provider-tests.md + filename: .github/failed-workflow-issue-templates/test-provider.md diff --git a/src/_nebari/provider/cloud/commons.py b/src/_nebari/provider/cloud/commons.py index 0cc3aa497e..ed1ed89b76 100644 --- a/src/_nebari/provider/cloud/commons.py +++ b/src/_nebari/provider/cloud/commons.py @@ -4,6 +4,6 @@ def filter_by_highest_supported_k8s_version(k8s_versions_list): filtered_k8s_versions_list = [] for k8s_version in k8s_versions_list: - if k8s_version <= HIGHEST_SUPPORTED_K8S_VERSION: + if k8s_version.split("-")[0] <= HIGHEST_SUPPORTED_K8S_VERSION: filtered_k8s_versions_list.append(k8s_version) return filtered_k8s_versions_list