From 64c545da286bb6b965a951f3177ed43ad61c96fb Mon Sep 17 00:00:00 2001 From: Moritz Date: Tue, 28 Jan 2025 13:27:05 +0100 Subject: [PATCH 1/4] bench(synth-bench): make binary selection more explicit --- benchmarks/synth-bm/justfile | 3 ++- docs/practices/workflows/benchmarking_synthetic_workloads.md | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/benchmarks/synth-bm/justfile b/benchmarks/synth-bm/justfile index 7645b04974f..bbd458e1801 100644 --- a/benchmarks/synth-bm/justfile +++ b/benchmarks/synth-bm/justfile @@ -1,4 +1,5 @@ -neard := "../../target/release/neard" +# Place the `neard` binary to be benchmarked here. +neard := "./neard" near_localnet_home := ".near/" rpc_url := "http://127.0.0.1:3030" diff --git a/docs/practices/workflows/benchmarking_synthetic_workloads.md b/docs/practices/workflows/benchmarking_synthetic_workloads.md index 121dc01b549..8d4f6999ede 100644 --- a/docs/practices/workflows/benchmarking_synthetic_workloads.md +++ b/docs/practices/workflows/benchmarking_synthetic_workloads.md @@ -78,8 +78,8 @@ Details of bringing up and configuring a network are out of scope for this docum ### Build `neard` -Choose the git commit and cargo features corresponding to what you want to benchmark. Most likely you will want a `--release` build to measure TPS. - +Choose the git commit and cargo features corresponding to what you want to benchmark. Most likely you will want a `--release` build to measure TPS. Place the corresponding `neard` binary in the justfile's directory or adjust commands and justfile variables to point to your binary. + ### Initialize the network ```command From 0e101332962914d612cc4cc662336437dc2a26ba Mon Sep 17 00:00:00 2001 From: Moritz Date: Tue, 28 Jan 2025 13:51:20 +0100 Subject: [PATCH 2/4] add cspell word --- docs/practices/workflows/benchmarking_synthetic_workloads.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/practices/workflows/benchmarking_synthetic_workloads.md b/docs/practices/workflows/benchmarking_synthetic_workloads.md index 8d4f6999ede..77e2fa6e357 100644 --- a/docs/practices/workflows/benchmarking_synthetic_workloads.md +++ b/docs/practices/workflows/benchmarking_synthetic_workloads.md @@ -113,4 +113,6 @@ Following these steps so far creates a config that will throttle throughput due } ``` +cspell:words + Note that as `nearcore` evolves, these steps and `BENCHMARKNET` adjustments might need to be updated to achieve the effect of unlimiting configuration. From 94f24c3759f0a92f501189ea861a07128c17ba0e Mon Sep 17 00:00:00 2001 From: Moritz Date: Wed, 29 Jan 2025 08:35:02 +0100 Subject: [PATCH 3/4] fix typo --- docs/practices/workflows/benchmarking_synthetic_workloads.md | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/practices/workflows/benchmarking_synthetic_workloads.md b/docs/practices/workflows/benchmarking_synthetic_workloads.md index 77e2fa6e357..d2c95a04c18 100644 --- a/docs/practices/workflows/benchmarking_synthetic_workloads.md +++ b/docs/practices/workflows/benchmarking_synthetic_workloads.md @@ -113,6 +113,5 @@ Following these steps so far creates a config that will throttle throughput due } ``` -cspell:words Note that as `nearcore` evolves, these steps and `BENCHMARKNET` adjustments might need to be updated to achieve the effect of unlimiting configuration. From f3a642bfc4ba75799430cc5a29dd090177da74c0 Mon Sep 17 00:00:00 2001 From: Moritz Date: Wed, 29 Jan 2025 16:04:52 +0100 Subject: [PATCH 4/4] Add binary to .gitignore --- benchmarks/synth-bm/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/benchmarks/synth-bm/.gitignore b/benchmarks/synth-bm/.gitignore index 6d244f57f97..d3fa05130b9 100644 --- a/benchmarks/synth-bm/.gitignore +++ b/benchmarks/synth-bm/.gitignore @@ -1,3 +1,4 @@ +neard .near/ target/ user-data/