Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

Indicate to users created accounts will be subdomains #307

Closed
kcole16 opened this issue Apr 6, 2020 · 6 comments
Closed

Indicate to users created accounts will be subdomains #307

kcole16 opened this issue Apr 6, 2020 · 6 comments
Assignees
Labels
bug Something isn't working P1 High priority

Comments

@kcole16
Copy link

kcole16 commented Apr 6, 2020

Overview

Once near/nearcore#2292 lands, near-shell should indicate to users that near create_account can only create:

  • Subdomains of the sending account --masterAccount
  • TLDs with >= 11 characters.

Example:
Using kendall.near, I can create accounts like test.kendall.near and hasatleasteleven.

cc @potatodepaulo @evgenykuzyakov

@kcole16 kcole16 changed the title Indicate that users can only create subdomains Indicate to users they must create accounts as subdomains Apr 6, 2020
@kcole16 kcole16 changed the title Indicate to users they must create accounts as subdomains Indicate to users created accounts will be subdomains Apr 6, 2020
@bowenwang1996
Copy link
Contributor

It seems that top level account names that are longer than 11 characters will still be allowed.

@ilblackdragon
Copy link
Member

We bumping account names that are allowed to 32 characters FYI.

@mikedotexe
Copy link
Contributor

mikedotexe commented Apr 22, 2020

I'm getting CreateAccountNotAllowed when I am trying this. Is this just disabled on testnet and fixed in the linked nearcore issue?
This was for creating a TLA:

Error:  CreateAccountNotAllowed [Error]: The new account_id hihihihihihi.test can't be created by asdf.test
    at Object.parseRpcError (/Users/mike/near/near-shell/node_modules/near-api-js/lib/utils/rpc_errors.js:25:19)
    at Account.signAndSendTransaction (/Users/mike/near/near-shell/node_modules/near-api-js/lib/account.js:114:36)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async LocalAccountCreator.createAccount (/Users/mike/near/near-shell/node_modules/near-api-js/lib/account_creator.js:23:9)
    at async Near.createAccount (/Users/mike/near/near-shell/node_modules/near-api-js/lib/near.js:52:9)
    at async createAccount (/Users/mike/near/near-shell/commands/create-account.js:73:5)
    at async Object.handler (/Users/mike/near/near-shell/utils/exit-on-error.js:4:9) {
  type: 'CreateAccountNotAllowed',
  index: 0,
  account_id: 'hihihihihihi.test',
  predecessor_id: 'asdf.test'

https://explorer.nearprotocol.com/transactions/9or889N3GcPE51KzxkPeyinBDEcZvTbhzFNZomgPgfsp

@bowenwang1996
Copy link
Contributor

@mikedotexe well, hihihihihihi.test is unfortunately not a TLA.

@mikedotexe
Copy link
Contributor

Darn, we need to reopen this and fix some issues Vlad saw this dev-deploy. My mistake for not catching it.

@mikedotexe mikedotexe reopened this Apr 28, 2020
@amgando amgando added the bug Something isn't working label May 12, 2020
@behaviary behaviary added the P1 High priority label May 12, 2020
@janedegtiareva
Copy link
Contributor

janedegtiareva commented Jun 10, 2020

PR is under review -- approved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working P1 High priority
Projects
None yet
Development

No branches or pull requests

7 participants