Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor actions to use latest schematic (post-refactor) #351

Merged

Conversation

adamjtaylor
Copy link
Contributor

Closes #340

@adamjtaylor adamjtaylor linked an issue Feb 28, 2024 that may be closed by this pull request
Copy link
Contributor Author

@adamjtaylor adamjtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In testing I get the warning

Lint CSV
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@adamjtaylor
Copy link
Contributor Author

Test PR #353 shows that the workflow runs and outputs the JSON-LD
Just want to update the checkout and python actions to make sure we overcome the node errors

@adamjtaylor
Copy link
Contributor Author

Comfirmed in a re-run of the action for test PR #353 that updating the versions. gets rid of the warnings. (note the last step fails due to the already existing JSON-LD but that is a known error and fine to leave as is.

@adamjtaylor adamjtaylor requested a review from elv-sb February 28, 2024 15:37
Copy link
Contributor

@elv-sb elv-sb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@adamjtaylor adamjtaylor merged commit dd3dc0e into main Feb 29, 2024
@adamjtaylor adamjtaylor deleted the 340-move-the-ci-to-use-the-refactored-schematic-version branch February 29, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the CI to use the refactored schematic version
2 participants