Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to basic filename regex #333

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Revert to basic filename regex #333

merged 2 commits into from
Dec 13, 2023

Conversation

adamjtaylor
Copy link
Contributor

@adamjtaylor adamjtaylor commented Dec 13, 2023

Fixes #328 by reverting to our old filename regex while we can figure out the regex escaping clashes in FDS-1416

@elv-sb I appreciate your review and then I propose we merge and make as a v23.12.1 release to allow the other features released in v23.11.1 to be avaliable to users again.

@adamjtaylor adamjtaylor requested a review from elv-sb December 13, 2023 16:57
Copy link
Contributor

@elv-sb elv-sb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@adamjtaylor adamjtaylor merged commit 8525b2e into main Dec 13, 2023
@adamjtaylor adamjtaylor deleted the revert-filename-regex branch December 13, 2023 17:51
@adamjtaylor adamjtaylor mentioned this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix filename regex
2 participants