Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTAN1 and HTAN2: Add I2 as a valid value for 'Read Indicator' #477

Closed
6 of 9 tasks
aclayton555 opened this issue Jan 14, 2025 · 4 comments · Fixed by #487
Closed
6 of 9 tasks

HTAN1 and HTAN2: Add I2 as a valid value for 'Read Indicator' #477

aclayton555 opened this issue Jan 14, 2025 · 4 comments · Fixed by #487
Assignees

Comments

@aclayton555
Copy link
Contributor

aclayton555 commented Jan 14, 2025

Information

Emerges from: https://sagebionetworks.jira.com/browse/HTAN-593

Proposed change:

  • Need to add I2 as a valid value for 'Read Indicator.' This would help with HTAN1 submissions but would also benefit HTAN2 submissions.
  • @adamjtaylor suggests that we add this to our our Phase 1 data model as a valid value for Read Indicator making sure that it filters up to our Phase 2 data model
  • This addition will trigger a HTAN1 data model release.

Implementation checklist

  • Branch created
  • HTAN.model.csv editied and pushed
  • HTAN.model.jsonld validated and created by Github action
  • PR opened
  • PR approved
  • PR merged into main
  • New Component added to ncihtan/HTAN-data-curator (if required)
  • DCA update requested
  • DCA updated
@aclayton555
Copy link
Contributor Author

@adamjtaylor and @aditigopalan do we want to do this within our 25-1 sprint or push to 25-2?

@aditigopalan
Copy link
Contributor

@aclayton555 i can work on this! 25-1

@aclayton555
Copy link
Contributor Author

aclayton555 commented Jan 30, 2025

@aditigopalan can I have you please validate this change on prod dca. If okay, please change status to In Production [Done]

@aditigopalan
Copy link
Contributor

As of 2/11 this is only available on dca-staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants