Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Accessory Template #345

Closed
9 tasks done
clarisse-lau opened this issue Feb 6, 2024 · 10 comments · Fixed by #346 or #349
Closed
9 tasks done

Create Accessory Template #345

clarisse-lau opened this issue Feb 6, 2024 · 10 comments · Fixed by #346 or #349
Assignees

Comments

@clarisse-lau
Copy link
Contributor

clarisse-lau commented Feb 6, 2024

The need for a mechanism to annotate and release accessory files has come up recently: HTAN-283 and HTAN-286

Based on discussions with @adamjtaylor, we will create a minimal record-based Accessory component which can be used to annotate Synapse files, folders, or datasets for any assay type.

RFC: https://docs.google.com/document/d/17v-K_5bODpqRJ9r34zkBLBvB2JymYdzZeAuBKBraUR8/edit#heading=h.weu01bl9qzmg

Implementation checklist

  • Branch created
  • HTAN.model.csv editied and pushed
  • HTAN.model.jsonld validated and created by Github action
  • PR opened
  • PR approved
  • PR merged into main
  • New Component added to ncihtan/HTAN-data-curator (if required)
  • DCA update requested
  • DCA updated
@aclayton555
Copy link
Contributor

aclayton555 commented Feb 16, 2024

@clarisse-lau is there a timeline by which we are trying to complete this template? I would like to make sure this is assigned accordingly to either the current or a future sprint. Thanks!

@clarisse-lau
Copy link
Contributor Author

No specific timelines, but there are a number of use cases which are awaiting this template, including the issues linked above, and re-annotation of HTAPP auxiliary folders.

@aclayton555
Copy link
Contributor

Noting this for our 24-3 sprint. Effort on this may occur prior to that sprint (during our 24-2 sprint), but we will at least prioritize this to be done within the 24-3 sprint.

@clarisse-lau
Copy link
Contributor Author

clarisse-lau commented Feb 17, 2024

Ok- thank you!
(just fyi, the PR is linked and is ready for review, but understand that as a new component this may take additional time to assess and refine)

@adamjtaylor
Copy link
Contributor

PR looks good. I am merging so that @clarisse-lau can test in staging prior to our sprint end.

@clarisse-lau
Copy link
Contributor Author

Thanks both! Is this still the link for staging? https://sagebio.shinyapps.io/HTAN-data-curator-staging/

@adamjtaylor
Copy link
Contributor

@clarisse-lau The staging instance is https://dca-staging.app.sagebionetworks.org/

@clarisse-lau
Copy link
Contributor Author

thank you @adamjtaylor :)

@adamjtaylor adamjtaylor reopened this Feb 19, 2024
@adamjtaylor
Copy link
Contributor

@clarisse-lau I've reopened as you'll need to make a PR to add the Accessory component to this config file

https://github.com/ncihtan/data-models/blob/main/dca-template-config.json

@adamjtaylor
Copy link
Contributor

@clarisse-lau That looks to be showing up in staging DCA now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants