Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output all separators in error message #164

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Output all separators in error message #164

merged 1 commit into from
Nov 8, 2023

Conversation

koppor
Copy link
Contributor

@koppor koppor commented Oct 22, 2023 •
edited
Loading

I think, the intention of [...] was to list all found separators, which I like.

Example

1:1  error  Expecting consistent version-date separator \u002d, found [\u2013]  consistent-separator

I adapted to code to output all (and also made use of the second and third parameter of joining to have the code even more clean.

Refs #163 (which is not reproducible with heylogs source on my local machine, but with heylogs binary)

@koppor koppor changed the base branch from master to develop October 22, 2023 08:32
@koppor koppor mentioned this pull request Nov 8, 2023
Closed
@charphi charphi merged commit 30cb4e5 into nbbrd:develop Nov 8, 2023
@charphi charphi added the enhancement New feature or request label Nov 9, 2023
@charphi charphi added this to the 0.7.2 milestone Nov 9, 2023
@koppor koppor deleted the output-all-separators branch November 15, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.7.2
Development

Successfully merging this pull request may close these issues.
2 participants
@koppor @charphi