Don't update last modification time for entries not being modified.

(issue #35)
navossoc · Jan 20, 2020 · 9990721 · 9990721
1 parent 75eddbe
commit 9990721
Showing 1 changed file with 17 additions and 2 deletions.
diff --git a/YAFD/FaviconDialog.cs b/YAFD/FaviconDialog.cs
@@ -134,8 +134,17 @@ private void BgWorker_DoWork(object sender, DoWorkEventArgs e)
                                             icons[i] = new PwCustomIcon(uuid, data);
                                         }
 
-                                        // Associate with this entry
-                                        entry.CustomIconUuid = uuid;
+                                        // Check if icon is the same
+                                        if (entry.CustomIconUuid.Equals(uuid))
+                                        {
+                                            // Avoid updating the entry
+                                            entries[i] = null;
+                                        }
+                                        else
+                                        {
+                                            // Associate with this entry
+                                            entry.CustomIconUuid = uuid;
+                                        }
 
                                         // Icon downloaded with success
                                         Interlocked.Increment(ref progress.Success);
@@ -154,6 +163,9 @@ private void BgWorker_DoWork(object sender, DoWorkEventArgs e)
                                             // Some other error (network, etc)
                                             Interlocked.Increment(ref progress.Error);
                                         }
+
+                                        // Avoid updating the entry
+                                        entries[i] = null;
                                     }
                                 }
                             }
@@ -252,6 +264,9 @@ private void BgWorker_RunWorkerCompleted(object sender, RunWorkerCompletedEventA
             // Update entries (avoid cross-thread operation with other plugins)
             foreach (PwEntry entry in entries)
             {
+                // You can't touch this (oh-oh oh oh oh-oh-oh)
+                if (entry == null) continue;
+
                 // Save it
                 entry.Touch(true, false);
             }