Skip to content
This repository has been archived by the owner on May 13, 2022. It is now read-only.

Minor design tweaks for widget height #26

Open
joehobson opened this issue Jul 10, 2014 · 3 comments
Open

Minor design tweaks for widget height #26

joehobson opened this issue Jul 10, 2014 · 3 comments
Assignees

Comments

@joehobson
Copy link
Member

grouping these 3 minor tweaks since they're all pretty much related...

I'd suggest we set the overall widget height to no more than 550px - will help cut down on some scrolling issues, not seeing the bottom of the widget. W3C stats show 45% of users have screen resolutions with height at 800pixels or less. resize your window to 800 height and view a page with the widget on it.

Window height of 800px:
screen shot 2014-07-10 at 12 12 13 pm


"filter by" area is too tall (63px). since we don't have Next/Previous anymore, maybe it could be moved to the right of the "showing X of XX" counter (in embed-search-pagination).

screen shot 2014-07-10 at 11 52 02 am


should specify line height for h3s within the widget css so that resources with multi-line titles don't look odd. many sites use line-height on headers. Actually I just looked at the filter-by issue above and it's also coming from line-height on the h2 on my site. Could be helped that way, but i think moving it to the right and up a line would be better.

screen shot 2014-07-10 at 11 51 50 am

@serpentblade
Copy link
Contributor

Rather than have to go back and forth on design changes here, I'd think it would be easier to have you commit the appropriate changes to public/css/embed.css

@joehobson
Copy link
Member Author

I spent a little time on Friday but ran into some issues getting all of the dependencies installed and working. My local dev copy comes up, but when I try to login with Persona i get a console error when the page refreshes

"Uncaught SecurityError: Failed to execute 'addEventListener' on 'EventTarget': Blocked a frame with origin "http://localhost:8888" from accessing a frame with origin "https://login.persona.org". The frame requesting access has a protocol of "http", the frame being accessed has a protocol of "https". Protocols must match."

Not sure exactly what to do there. The 3 design changes above are pretty minor and I think I described them pretty clearly so I don't know what back-and-forth we would need. Just looking for some improvements to reduce the overall vertical space a little. I can spend a little more time with my local copy, but i'm sure that's not the most efficient way, especially considering youre using SCSS.

@serpentblade
Copy link
Contributor

Without details I can't offer any insight into that persona security error. I think it would be beneficial in the long term to get your local copy working in order to make quick changes down the road if needed. I don't quite understand what you mean about moving the filter stuff, that section opens up to a lot of information that can't be squeezed up there.

Also we aren't using SCSS, the SCSS files are just the original files sent by the designer, the public/css/embed.css is a normal CSS file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants