Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: implement builders for using with NG CLI #883

Closed
SuperITMan opened this issue Nov 26, 2018 · 5 comments · Fixed by #1148
Closed

build: implement builders for using with NG CLI #883

SuperITMan opened this issue Nov 26, 2018 · 5 comments · Fixed by #1148
Labels
comp: stark-build Stark Build
Milestone
10.0.0-beta.5

Comments

@SuperITMan
Copy link
Member

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

We use npm scripts to run our application.

Expected behavior

We should use the CLI build and add our customisations thanks to angular builders in stark-build.

What is the motivation / use case for changing the behavior?

Angular team is improving the build system a lot (performance, bundle size, etc.) and we should take advantage of this instead of trying to follow them progressively.
@SuperITMan SuperITMan added the comp: stark-build Stark Build label Nov 26, 2018
@SuperITMan SuperITMan added this to the 10.0.0-beta.2 milestone Nov 26, 2018
@SuperITMan SuperITMan self-assigned this Nov 26, 2018
@SuperITMan
Copy link
Member Author

this is linked to #114

@dsebastien
Copy link
Contributor

Great!
This will contribute to #146

@dsebastien
Copy link
Contributor

Any chance of getting a better integration with Angular CLI in the coming releases?

@christophercr
Copy link
Collaborator

Indeed, we'll work on it in the coming weeks so we plan to include it in the first RC 😉

@christophercr christophercr mentioned this issue Feb 13, 2019
Open
@dsebastien dsebastien mentioned this issue Feb 13, 2019
Closed
3 tasks
This was referenced Feb 13, 2019
Open
Closed
Closed
Merged
Closed
@christophercr
Copy link
Collaborator

christophercr commented Feb 20, 2019 •
edited
Loading

We will use @angular-builders to customize the webpack config to be used with Angular CLI.

References:

christophercr referenced this issue in christophercr/stark Feb 21, 2019
@christophercr
feat(stark-build): implement integration with Angular CLI via @angula…
6b1901c 
…r-builders

ISSUES CLOSED: #883
christophercr referenced this issue in christophercr/stark Feb 22, 2019
@christophercr
feat(stark-build): implement integration with Angular CLI via @angula…
ed7bf2b 
…r-builders

ISSUES CLOSED: #883
@christophercr christophercr mentioned this issue Feb 22, 2019
Merged
3 tasks
christophercr referenced this issue in christophercr/stark Feb 22, 2019
@christophercr
feat(stark-build): implement integration with Angular CLI via @angula…
f24adbc 
…r-builders

ISSUES CLOSED: #883
christophercr referenced this issue in christophercr/stark Feb 22, 2019
@christophercr
feat(stark-build): implement integration with Angular CLI via @angula…
3b5e1dc 
…r-builders

ISSUES CLOSED: #883
christophercr referenced this issue in christophercr/stark Feb 22, 2019
@christophercr
feat(stark-build): implement integration with Angular CLI via @angula…
b26b40c 
…r-builders

ISSUES CLOSED: #883
christophercr referenced this issue in christophercr/stark Feb 22, 2019
@christophercr
feat(stark-build): implement integration with Angular CLI via @angula…
7b9326e 
…r-builders

ISSUES CLOSED: #883
christophercr referenced this issue in christophercr/stark Feb 25, 2019
@christophercr
feat(stark-build): implement integration with Angular CLI via @angula…
91eeb47 
…r-builders

ISSUES CLOSED: #883
christophercr referenced this issue in christophercr/stark Feb 25, 2019
@christophercr
feat(stark-build): implement integration with Angular CLI via @angula…
a03d172 
…r-builders

ISSUES CLOSED: #883
christophercr referenced this issue in christophercr/stark Feb 26, 2019
@christophercr
feat(stark-build): implement integration with Angular CLI via @angula…
b91c616 
…r-builders

ISSUES CLOSED: #883
christophercr referenced this issue in christophercr/stark Feb 26, 2019
@christophercr
feat(stark-build): implement integration with Angular CLI via @angula…
87c43cf 
…r-builders

ISSUES CLOSED: #883, #146, 114
christophercr referenced this issue in christophercr/stark Feb 26, 2019
@christophercr
feat(stark-build): implement integration with Angular CLI via @angula…
b97756c 
…r-builders

ISSUES CLOSED: #883, #146, 114

BREAKING CHANGE: stark-build now integrates with Angular CLI:

   - **stark-build:** now provides partial Webpack configurations to override default configuration from Angular CLI. The application's `angular.json` file must be adapted to use this partial configs from stark-build via [@angular-builders](https://github.com/meltedspark/angular-builders). See [Stark-Build: Ng CLI Customizations](./docs/stark-build/NG_CLI_BUILD_CUSTOMIZATIONS.md)
   - **stark-core:** the application's `angular.json` file must be adapted to add the assets from stark-core to be copied to the application's `assets` folder. See [Stark-Core: Getting Started](./docs/stark-core/GETTING_STARTED.md#assets)
   - **stark-ui:** the application's `angular.json` file must be adapted to add the assets from stark-ui to be copied to the application's `assets` folder. See [Stark-UI: Getting Started](./docs/stark-ui/GETTING_STARTED.md#assets)
christophercr referenced this issue in christophercr/stark Feb 26, 2019
@christophercr
feat(stark-build): implement integration with Angular CLI via @angula…
9a26c00 
…r-builders

ISSUES CLOSED: #883, #146, #114

BREAKING CHANGE: stark-build now integrates with Angular CLI:

   - **stark-build:** now provides partial Webpack configurations to override default configuration from Angular CLI. The application's `angular.json` file must be adapted to use this partial configs from stark-build via [@angular-builders](https://github.com/meltedspark/angular-builders). See [Stark-Build: Ng CLI Customizations](./docs/stark-build/NG_CLI_BUILD_CUSTOMIZATIONS.md)
   - **stark-core:** the application's `angular.json` file must be adapted to add the assets from stark-core to be copied to the application's `assets` folder. See [Stark-Core: Getting Started](./docs/stark-core/GETTING_STARTED.md#assets)
   - **stark-ui:** the application's `angular.json` file must be adapted to add the assets from stark-ui to be copied to the application's `assets` folder. See [Stark-UI: Getting Started](./docs/stark-ui/GETTING_STARTED.md#assets)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-build Stark Build
Projects
None yet
Milestone
10.0.0-beta.5
Development

Successfully merging a pull request may close this issue.

feat(stark-build): implement integration with Angular CLI via @angular-builders christophercr/stark
3 participants
@dsebastien @christophercr @SuperITMan