Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: dialogs - implement re-usable Angular Material dialog components #793

Closed
dsebastien opened this issue Oct 25, 2018 · 2 comments · Fixed by #1183
Closed

ui: dialogs - implement re-usable Angular Material dialog components #793

dsebastien opened this issue Oct 25, 2018 · 2 comments · Fixed by #1183

Comments

@dsebastien
Copy link
Contributor

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Expected behavior

We should integrate the dialog component that we had in the previous Stark release, unless its feature set can be covered fully by Angular Material..

@christophercr
Copy link
Collaborator

As discussed with @SuperITMan, this feature is provided by Angular Material so we won't re-implement such feature in Stark 10.

However we could still provide a preset of Dialog components like we did before: confirm, alert and prompt so the developer can re-use them if he wants to instead of duplicating code every time and along different apps.

@christophercr christophercr changed the title ui: dialogs - implement component/module ui: dialogs - implement re-usable Angular Material dialog components Feb 12, 2019
@dsebastien
Copy link
Contributor Author

+1

@christophercr christophercr self-assigned this Mar 1, 2019
christophercr referenced this issue in christophercr/stark Mar 6, 2019
christophercr referenced this issue in christophercr/stark Mar 6, 2019
christophercr referenced this issue in christophercr/stark Mar 6, 2019
christophercr referenced this issue in christophercr/stark Mar 7, 2019
christophercr referenced this issue in christophercr/stark Mar 8, 2019
christophercr referenced this issue in christophercr/stark Mar 8, 2019
christophercr referenced this issue in christophercr/stark Mar 11, 2019
christophercr referenced this issue in christophercr/stark Mar 11, 2019
christophercr referenced this issue in christophercr/stark Mar 11, 2019
christophercr referenced this issue in christophercr/stark Mar 11, 2019
christophercr referenced this issue in christophercr/stark Mar 12, 2019
christophercr referenced this issue in christophercr/stark Mar 12, 2019
christophercr referenced this issue in christophercr/stark Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants