Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: release-it did not upgrade stark version in package-lock.json during the latest release #574

Closed
SuperITMan opened this issue Jul 31, 2018 · 1 comment · Fixed by #579

Comments

@SuperITMan
Copy link
Member

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

release-it does not adapt version in package-lock.json

Expected behavior

release-it should upgrade version in package-lock.json

@SuperITMan SuperITMan added this to the 10.0.0-alpha.5 milestone Jul 31, 2018
@christophercr
Copy link
Collaborator

christophercr commented Jul 31, 2018

Apparently we can change the pkgFiles option in the release-it config file to include the package-lock.json:

release-it/release-it#147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants