Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showcase: baseHref and deployUrl were not replaced in some files during the latest release #571

Closed
SuperITMan opened this issue Jul 31, 2018 · 0 comments · Fixed by #577
Closed

Comments

@SuperITMan
Copy link
Member

SuperITMan commented Jul 31, 2018

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

The placeholders : <stark-dummy-base-href> and <stark-dummy-deploy-url> are not replaced after the build.

Expected behavior

The placeholders : <stark-dummy-base-href> and <stark-dummy-deploy-url> should be replaced after the build.

Minimal reproduction of the problem with instructions

Go on Stark showcase and look at the home page.
You'll see no image in the squares because the URL in the CSS is incorrect.

Environment


Angular version: 6.0.9
Stark version: 10.0.0-alpha.4
@SuperITMan SuperITMan added this to the 10.0.0-alpha.5 milestone Jul 31, 2018
@christophercr christophercr changed the title showcase: baseHref is not working showcase: baseHref and deployUrl were not replaced in some files during the latest release Jul 31, 2018
@christophercr christophercr self-assigned this Jul 31, 2018
christophercr referenced this issue in christophercr/stark Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants