-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: svg viewbox directive - style not applied on scoped SCSS #504
Milestone
Comments
"Fix starksvgviewbox directive" |
3 tasks
carlo-nomes
added a commit
to carlo-nomes/stark
that referenced
this issue
Jan 15, 2019
- add StarkSvgViewBoxModule to shared modules - offset icon slightly to compensate @angular/material update - update icon scaling functionality after correct `starkSvgViewBox` implementation ISSUES CLOSED: NationalBankBelgium#504 NationalBankBelgium#1030
carlo-nomes
added a commit
to carlo-nomes/stark
that referenced
this issue
Jan 15, 2019
- add StarkSvgViewBoxModule to shared modules - offset icon slightly to compensate @angular/material update - update icon scaling functionality after correct `starkSvgViewBox` implementation ISSUES CLOSED: NationalBankBelgium#504 NationalBankBelgium#1030
carlo-nomes
added a commit
to carlo-nomes/stark
that referenced
this issue
Jan 15, 2019
- add StarkSvgViewBoxModule to shared modules - offset icon slightly to compensate @angular/material update - update icon scaling functionality after correct `starkSvgViewBox` implementation ISSUES CLOSED: NationalBankBelgium#504 NationalBankBelgium#1030
Apparently this issue was caused by the fact that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm submitting a...
Current behavior
The svg tag inside the mat-icon doesn't reflect its parent scope.
Expected behavior
We should add the scope to the svg tag
Minimal reproduction of the problem with instructions
Create a page in the showcase, add an icon button and change the width and height on the scoped SCSS
SCSS:
.mat-icon-button { .mat-icon svg { height: 15px; width: 15px; } }
HTML:
<button mat-icon-button><mat-icon starkSvgViewBox svgIcon="heart"></mat-icon></button>
The text was updated successfully, but these errors were encountered: