Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: svg viewbox directive - style not applied on scoped SCSS #504

Closed
catlabs opened this issue Jul 13, 2018 · 2 comments · Fixed by #1039
Closed

ui: svg viewbox directive - style not applied on scoped SCSS #504

catlabs opened this issue Jul 13, 2018 · 2 comments · Fixed by #1039

Comments

@catlabs
Copy link
Contributor

catlabs commented Jul 13, 2018

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

The svg tag inside the mat-icon doesn't reflect its parent scope.

Expected behavior

We should add the scope to the svg tag

Minimal reproduction of the problem with instructions

Create a page in the showcase, add an icon button and change the width and height on the scoped SCSS

SCSS:
.mat-icon-button { .mat-icon svg { height: 15px; width: 15px; } }

HTML:
<button mat-icon-button><mat-icon starkSvgViewBox svgIcon="heart"></mat-icon></button>

@carlo-nomes
Copy link
Collaborator

"Fix starksvgviewbox directive"

carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Jan 15, 2019
  - add StarkSvgViewBoxModule to shared modules
  - offset icon slightly to compensate @angular/material update
  - update icon scaling functionality after correct `starkSvgViewBox` implementation

ISSUES CLOSED: NationalBankBelgium#504 NationalBankBelgium#1030
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Jan 15, 2019
  - add StarkSvgViewBoxModule to shared modules
  - offset icon slightly to compensate @angular/material update
  - update icon scaling functionality after correct `starkSvgViewBox` implementation

ISSUES CLOSED: NationalBankBelgium#504 NationalBankBelgium#1030
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Jan 15, 2019
  - add StarkSvgViewBoxModule to shared modules
  - offset icon slightly to compensate @angular/material update
  - update icon scaling functionality after correct `starkSvgViewBox` implementation

ISSUES CLOSED: NationalBankBelgium#504 NationalBankBelgium#1030
@christophercr
Copy link
Collaborator

Apparently this issue was caused by the fact that the SvgViewBoxModule was not imported in every module of the Starter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants