Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add support for environments #50

Closed
dsebastien opened this issue Mar 1, 2018 · 1 comment · Fixed by #454
Closed

build: add support for environments #50

dsebastien opened this issue Mar 1, 2018 · 1 comment · Fixed by #454
Labels
comp: stark-build Stark Build effort: hours must P1 type: feature
Milestone
10.0.0-alpha.4

Comments

@dsebastien
Copy link
Contributor

dsebastien commented Mar 1, 2018 •
edited
Loading

Assuming the build specifies the environment (either default value or provided as CLI argument), make sure we have support for finding out the current environment within Stark apps (programmatically)

This requires some cleanup as we currently have (at least) these:

  • webpack options
  • Define plugin
  • src/environments/environments.ts: provides programmatic checks (if env === ...)
  • custom-typings.d.ts: probably doesn't need any typings for the env anymore!
  • HTML templating
  • polyfills.browser.ts
@dsebastien dsebastien added this to the 10.0.0-alpha.1 milestone Mar 1, 2018
@dsebastien dsebastien modified the milestones: 10.0.0-alpha.1, sprint 1 Mar 19, 2018
@dsebastien dsebastien added the P1 label Apr 24, 2018
@dsebastien dsebastien modified the milestones: sprint 1, 10.0.0-alpha.3 May 8, 2018
@Mallikki Mallikki self-assigned this Jun 12, 2018
Mallikki added a commit to Mallikki/stark that referenced this issue Jun 13, 2018
@Mallikki
docs(build): documented environment support
31af969 
ISSUES CLOSED: NationalBankBelgium#50
@Mallikki Mallikki mentioned this issue Jun 13, 2018
Merged
3 tasks
Mallikki added a commit to Mallikki/stark that referenced this issue Jun 14, 2018
@Mallikki
docs(build): documented environment support
96811ab 
ISSUES CLOSED: NationalBankBelgium#50
Mallikki added a commit to Mallikki/stark that referenced this issue Jun 14, 2018
@Mallikki
docs(docs): documented environment support
185fe24 
ISSUES CLOSED: NationalBankBelgium#50
@christophercr christophercr reopened this Jun 18, 2018
@christophercr
Copy link
Collaborator

Re-opened this issue since it is not completely solved.

Currently it is not possible to programatically check the current enviroment in the stark packages, only in the client application (i.e. starter or showcase).

christophercr referenced this issue in christophercr/stark Jun 20, 2018
@christophercr
feat(stark-build): add support for environment variables at runtime (…
b0934e1 
…importing environment.ts file) and at compilation time (using webpack Define plugin)

ISSUES CLOSED: #50
christophercr referenced this issue in christophercr/stark Jun 20, 2018
@christophercr
feat(stark-build): add support for environment variables at runtime (…
1a7fea8 
…importing environment.ts file) and at compilation time (using webpack Define plugin)

ISSUES CLOSED: #50
christophercr referenced this issue in christophercr/stark Jun 21, 2018
@christophercr
feat(stark-build): add support for environment variables at runtime (…
8ff7e35 
…importing environment.ts file) and at compilation time (using webpack Define plugin)

ISSUES CLOSED: #50
christophercr referenced this issue in christophercr/stark Jun 21, 2018
@christophercr
feat(stark-build): add support for environment variables at runtime (…
4de2a24 
…importing environment.ts file) and at compilation time (using webpack Define plugin)

ISSUES CLOSED: #50
christophercr referenced this issue in christophercr/stark Jun 21, 2018
@christophercr
feat(stark-build): add support for environment variables at runtime (…
c96c213 
…importing environment.ts file) and at compilation time (using webpack Define plugin)

ISSUES CLOSED: #50
@christophercr christophercr mentioned this issue Jun 21, 2018
Merged
3 tasks
christophercr referenced this issue in christophercr/stark Jun 21, 2018
@christophercr
feat(stark-build): add support for environment variables at runtime (…
5223723 
…importing environment.ts file) and at compilation time (using webpack Define plugin)

ISSUES CLOSED: #50
christophercr referenced this issue in christophercr/stark Jun 22, 2018
@christophercr
feat(stark-build): add support for environment variables at runtime (…
cb95bbd 
…importing environment.ts file) and at compilation time (using webpack Define plugin)

ISSUES CLOSED: #50
christophercr referenced this issue in christophercr/stark Jun 22, 2018
@christophercr
feat(stark-build): add support for environment variables at runtime (…
e3b5a22 
…importing environment.ts file) and at compilation time (using webpack Define plugin)

ISSUES CLOSED: #50
christophercr referenced this issue in christophercr/stark Jun 22, 2018
@christophercr
feat(stark-build): add support for environment variables at runtime (…
c6ff2fe 
…importing environment.ts file) and at compilation time (using webpack Define plugin)

ISSUES CLOSED: #50
christophercr referenced this issue in christophercr/stark Jun 22, 2018
@christophercr
feat(stark-build): add support for environment variables at runtime (…
75a81fc 
…importing environment.ts file) and at compilation time (using webpack Define plugin)

ISSUES CLOSED: #50
christophercr referenced this issue in christophercr/stark Jun 22, 2018
@christophercr
feat(stark-build): add support for environment variables at runtime (…
7ec7eb5 
…importing environment.ts file) and at compilation time (using webpack Define plugin)

ISSUES CLOSED: #50
christophercr referenced this issue in christophercr/stark Jun 26, 2018
@christophercr
feat(stark-build): add support for environment variables at runtime (…
cee688d 
…importing environment.ts file) and at compilation time (using webpack Define plugin)

ISSUES CLOSED: #50
christophercr referenced this issue in christophercr/stark Jun 26, 2018
@christophercr
feat(stark-build): add support for environment variables at runtime (…
310ff36 
…importing environment.ts file) and at compilation time (using webpack Define plugin)

ISSUES CLOSED: #50
christophercr referenced this issue in christophercr/stark Jun 26, 2018
@christophercr
feat(stark-build): add support for environment variables at runtime (…
6c4cb94 
…importing environment.ts file) and at compilation time (using webpack Define plugin)

ISSUES CLOSED: #50
christophercr referenced this issue in christophercr/stark Jun 26, 2018
@christophercr
feat(stark-build): add support for environment variables at runtime (…
4afe018 
…importing environment.ts file) and at compilation time (using webpack Define plugin)

ISSUES CLOSED: #50
christophercr referenced this issue in christophercr/stark Jun 26, 2018
@christophercr
feat(stark-build): add support for environment variables at runtime (…
b17fdc6 
…importing environment.ts file) and at compilation time (using webpack Define plugin)

ISSUES CLOSED: #50
christophercr referenced this issue in christophercr/stark Jun 26, 2018
@christophercr
feat(stark-build): add support for environment variables at runtime (…
1b220f3 
…importing environment.ts file) and at compilation time (using webpack Define plugin)

ISSUES CLOSED: #50
christophercr referenced this issue in christophercr/stark Jun 26, 2018
@christophercr
feat(stark-build): add support for environment variables at runtime (…
8f246f6 
…importing environment.ts file) and at compilation time (using webpack Define plugin)

ISSUES CLOSED: #50
christophercr referenced this issue in christophercr/stark Jun 26, 2018
@christophercr
feat(stark-build): add support for environment variables at runtime (…
c29e36b 
…importing environment.ts file) and at compilation time (using webpack Define plugin)

ISSUES CLOSED: #50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-build Stark Build effort: hours must P1 type: feature
Projects
None yet
Milestone
10.0.0-alpha.4
3 participants
@dsebastien @christophercr @Mallikki