Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: automatically update the version to the next path/minor after a release #420

Closed
dsebastien opened this issue Jun 6, 2018 · 0 comments · Fixed by #1185
Closed

Comments

@dsebastien
Copy link
Contributor

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

If we look at our GitHub releases, we can see that the only released version is 10.0.0-alpha.2: https://github.com/NationalBankBelgium/stark/releases

Although when we look at npm, we notice that the "latest" tag points to an alpha.1: https://www.npmjs.com/package/@nationalbankbelgium/stark-build?activeTab=versions

Also, the "next" tag points to alpha.2.

This means that:

  • we might have done something wrong with our last actual released (i.e., tag)
  • the package.json file was not adapted correctly and should be alpha.3 at this point, to clearly indicate that our nightly builds are what will ultimately become alpha.3

Expected behavior

  • the "latest" tag should point to the actual tagged version in GH
  • the package.json version should point to the next patch/minor directly after the tag/push of a release
@christophercr christophercr added this to the 10.0.0-beta.5 milestone Feb 15, 2019
@christophercr christophercr self-assigned this Mar 13, 2019
christophercr referenced this issue in christophercr/stark Mar 13, 2019
…release. Refactor nightly build

ISSUES CLOSED: #420, #468
christophercr referenced this issue in christophercr/stark Mar 13, 2019
…release. Fix nightly build versioning

ISSUES CLOSED: #420, #468
christophercr referenced this issue in christophercr/stark Mar 13, 2019
…release. Fix nightly builds versioning

ISSUES CLOSED: #420, #468
christophercr referenced this issue in christophercr/stark Mar 13, 2019
…release. Fix nightly builds versioning

ISSUES CLOSED: #420, #468
christophercr referenced this issue in christophercr/stark Mar 13, 2019
…release. Fix nightly builds versioning

ISSUES CLOSED: #420, #468
christophercr referenced this issue in christophercr/stark Mar 13, 2019
…release. Fix nightly builds versioning

ISSUES CLOSED: #420, #468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants