Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: integrate custom HMR bootstraping into stark-core #412

Closed
christophercr opened this issue Jun 5, 2018 · 4 comments
Closed

build: integrate custom HMR bootstraping into stark-core #412

christophercr opened this issue Jun 5, 2018 · 4 comments
Labels
comp: stark-build Stark Build must type: feature
Milestone
10.0.0-alpha.4

Comments

@christophercr
Copy link
Collaborator

christophercr commented Jun 5, 2018 •
edited
Loading

Goal: move the custom HMR bootstraping logic into stark-build stark-core.

Currently we just copied the HMR bootstraping from the Angular Class starter.

Document this feature
@christophercr christophercr changed the title build: integrate HMR into stark-build build: integrate custom HMR bootstraping into stark-build Jun 5, 2018
@dsebastien dsebastien added this to the must milestone Jun 5, 2018
@dsebastien dsebastien modified the milestones: must, 10.0.0-alpha.4 Jun 26, 2018
SuperITMan referenced this issue in SuperITMan/stark Jul 2, 2018
@ageorges-nbb
feat(stark-all): integrate HMR bootstraping into stark-build
ba60e7a 
ISSUES CLOSED: #412
@SuperITMan SuperITMan mentioned this issue Jul 2, 2018
Closed
@dsebastien
Copy link
Contributor

Just wondering, but why put the HMR bit in stark build rather than in stark core?
AFAIK, there's also an integration to do with NGRX.

I'll publish my "bootstrap" branch, I started taking that but couldn't move forward with it

@dsebastien
Copy link
Contributor

See here: #112 (comment)

dsebastien added a commit to dsebastien/stark that referenced this issue Jul 3, 2018
@dsebastien
feat(core): integrated bootstrap
4e70125 
Closes NationalBankBelgium#112 NationalBankBelgium#412
@dsebastien dsebastien mentioned this issue Jul 3, 2018
Closed
3 tasks
dsebastien added a commit to dsebastien/stark that referenced this issue Jul 5, 2018
@dsebastien
feat(core): integrated bootstrap
83f41e9 
Closes NationalBankBelgium#112 NationalBankBelgium#412
dsebastien added a commit to dsebastien/stark that referenced this issue Jul 5, 2018
@dsebastien
feat(core): integrated bootstrap
d8151c8 
Closes NationalBankBelgium#112 NationalBankBelgium#412
dsebastien added a commit to dsebastien/stark that referenced this issue Jul 6, 2018
@dsebastien
feat(core): integrated bootstrap
84eae45 
Closes NationalBankBelgium#112 NationalBankBelgium#412
dsebastien added a commit to dsebastien/stark that referenced this issue Jul 6, 2018
@dsebastien
feat(core): integrated bootstrap
1d54446 
Closes NationalBankBelgium#112 NationalBankBelgium#412
dsebastien added a commit to dsebastien/stark that referenced this issue Jul 6, 2018
@dsebastien
feat(core): integrated bootstrap
b2ef7b2 
Closes NationalBankBelgium#112 NationalBankBelgium#412
@dsebastien dsebastien mentioned this issue Jul 6, 2018
Merged
3 tasks
@christophercr
Copy link
Collaborator Author

Indeed, it should be part of stark-core... so I'll rename this issue ;)

@christophercr christophercr changed the title build: integrate custom HMR bootstraping into stark-build build: integrate custom HMR bootstraping into stark-core Jul 6, 2018
dsebastien added a commit to dsebastien/stark that referenced this issue Jul 6, 2018
@dsebastien
feat(core): integrated bootstrap
97ca29e 
Closes NationalBankBelgium#112 NationalBankBelgium#412
@christophercr
Copy link
Collaborator Author

Closed by #486

@dsebastien dsebastien removed the P1 label Jul 9, 2018
@SuperITMan SuperITMan removed their assignment Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-build Stark Build must type: feature
Projects
None yet
Milestone
10.0.0-alpha.4
Development

No branches or pull requests
3 participants
@dsebastien @christophercr @SuperITMan