Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stark-build: add circular-dependency-plugin #315

Closed
SuperITMan opened this issue Apr 18, 2018 · 1 comment
Closed

stark-build: add circular-dependency-plugin #315

SuperITMan opened this issue Apr 18, 2018 · 1 comment
Labels
comp: stark-build Stark Build must type: enhancement
Milestone
10.0.0-alpha.3

Comments

@SuperITMan
Copy link
Member

SuperITMan commented Apr 18, 2018 •
edited
Loading

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

Code can contain circular dependencies

Expected behavior

No circular dependency.

What is the motivation / use case for changing the behavior?

Avoid circular dependencies.
@dsebastien dsebastien added this to the 10.0.0-alpha.1 milestone Apr 23, 2018
@dsebastien dsebastien changed the title Add circular-dependency-plugin to Stark-Build stark-build: add circular-dependency-plugin Apr 23, 2018
dsebastien added a commit to dsebastien/stark that referenced this issue Jun 2, 2018
@dsebastien
fix(build): fixed webpack config and circular-dependency-plugin config.
7813218 
Closes NationalBankBelgium#397, NationalBankBelgium#315
@dsebastien dsebastien mentioned this issue Jun 2, 2018
Merged
3 tasks
dsebastien added a commit to dsebastien/stark that referenced this issue Jun 2, 2018
@dsebastien
fix(build): fixed webpack config and circular-dependency-plugin config.
9f4cd05 
Closes NationalBankBelgium#397, NationalBankBelgium#315
dsebastien added a commit to dsebastien/stark that referenced this issue Jun 3, 2018
@dsebastien
fix(build): fixed webpack config and circular-dependency-plugin config.
ea9c264 
Closes NationalBankBelgium#397, NationalBankBelgium#315
@christophercr
Copy link
Collaborator

Closed by #400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-build Stark Build must type: enhancement
Projects
None yet
Milestone
10.0.0-alpha.3
Development

No branches or pull requests
3 participants
@dsebastien @christophercr @SuperITMan