Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security issue: typo in noopener on link rel #1971

Closed
dsebastien opened this issue Jun 4, 2020 · 0 comments · Fixed by #2024
Closed

security issue: typo in noopener on link rel #1971

dsebastien opened this issue Jun 4, 2020 · 0 comments · Fixed by #2024

Comments

@dsebastien
Copy link
Contributor

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

The following lines have a security bug:

Expected behavior

The rel's value should be noreferrer noopener.

Reference: https://web.dev/external-anchors-use-rel-noopener/

@SuperITMan SuperITMan added this to the 10.1.0 milestone Jul 1, 2020
@dm148 dm148 self-assigned this Jul 2, 2020
dm148 pushed a commit to dm148/stark that referenced this issue Jul 2, 2020
dm148 added a commit to dm148/stark that referenced this issue Jul 3, 2020
dm148 added a commit to dm148/stark that referenced this issue Jul 3, 2020
dm148 added a commit to dm148/stark that referenced this issue Jul 3, 2020
dm148 added a commit to dm148/stark that referenced this issue Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants