Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: provide a way to set the base href #148

Closed
dsebastien opened this issue Mar 3, 2018 · 5 comments · Fixed by #374
Closed

build: provide a way to set the base href #148

dsebastien opened this issue Mar 3, 2018 · 5 comments · Fixed by #374
Labels
comp: stark-build Stark Build comp: stark-starter Stark Starter
Milestone
10.0.0-alpha.3

Comments

@dsebastien
Copy link
Contributor

dsebastien commented Mar 3, 2018 •
edited
Loading

Add a way to customize the base href value easily

With this: BaseHrefWebpackPlugin: https://www.npmjs.com/package/base-href-webpack-plugin
We could pass the value to use as an input parameter to the cmd line

Corresponding internal issue: NG-1725
@dsebastien dsebastien added this to the should milestone Mar 3, 2018
@SuperITMan
Copy link
Member

For CSS part, we should include PostCSS plugins settings from NG Cli which include config for base path in url in CSS properties

@dsebastien dsebastien added must and removed should labels Mar 7, 2018
@dsebastien dsebastien modified the milestones: should, must Mar 7, 2018
@dsebastien dsebastien added the P1 label Apr 24, 2018
@dsebastien dsebastien mentioned this issue Apr 24, 2018
Closed
28 tasks
@dsebastien dsebastien modified the milestones: must, 10.0.0-alpha.3 May 3, 2018
@dsebastien
Copy link
Contributor Author

Ideally we should support the angular cli ng build command (@SuperITMan: do we already?), and its --base-href flag: https://stackoverflow.com/questions/38112891/angular-2-4-5-set-base-href-dynamically

@dsebastien
Copy link
Contributor Author

In addition, we should also configure this via the ng cli config file as shown here: angular/angular-cli#6477

@christophercr christophercr self-assigned this May 14, 2018
christophercr referenced this issue in christophercr/stark May 16, 2018
@christophercr
feat(build): add support for custom baseHref and deployUrl in angular…
cf941bd 
…-cli.json file with BaseHrefWebpackPlugin

ISSUES CLOSED: #148
@christophercr christophercr mentioned this issue May 16, 2018
Merged
3 tasks
@dsebastien
Copy link
Contributor Author

@christophercr can you write some docs for this feature?

@christophercr christophercr mentioned this issue May 23, 2018
Merged
3 tasks
@christophercr
Copy link
Collaborator

Sure, I've created a PR for that (#385)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-build Stark Build comp: stark-starter Stark Starter
Projects
None yet
Milestone
10.0.0-alpha.3
3 participants
@dsebastien @christophercr @SuperITMan