Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: table - cell click does not trigger "onClickCallback" #1466

Closed
SuperITMan opened this issue Dec 17, 2019 · 0 comments · Fixed by #1467
Closed

ui: table - cell click does not trigger "onClickCallback" #1466

SuperITMan opened this issue Dec 17, 2019 · 0 comments · Fixed by #1467
Labels
comp: stark-ui type: bug
Milestone
10.0.0-rc.3

Comments

@SuperITMan
Copy link
Member

SuperITMan commented Dec 17, 2019 •
edited
Loading

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

When the columnProperties object has the property onClickCallback set for a column. If a user click on a cell of the column, the method onClickCallback is never triggered.

Expected behavior

When the columnProperties object has the property onClickCallback set for a column, it should be triggered when a user clicks on a cell of the column.

What is the motivation / use case for changing the behavior?

Bug fixing.

Environment


Angular version: X.Y.Z
Stark version: 10.0.0-beta.0 -> 10.0.0-rc.2
@SuperITMan SuperITMan added this to the 10.0.0-rc.3 milestone Dec 17, 2019
@SuperITMan SuperITMan self-assigned this Dec 17, 2019
SuperITMan referenced this issue in SuperITMan/stark Dec 17, 2019
@SuperITMan
feat(stark-ui): add support for onClickCallback column properties i…
e72785e 
…n Table component

ISSUES CLOSED: #1466
@SuperITMan SuperITMan mentioned this issue Dec 17, 2019
Merged
3 tasks
@christophercr christophercr changed the title ui: table - cell click does not triggered "onClickCallback" ui: table - cell click does not trigger "onClickCallback" Dec 17, 2019
SuperITMan referenced this issue in SuperITMan/stark Dec 18, 2019
@SuperITMan
fix(stark-ui): add support for onClickCallback column properties in…
8401d56 
… Table component

Add `cellClicked` output in StarkTableColumnComponent.

ISSUES CLOSED: #1466
SuperITMan referenced this issue in SuperITMan/stark Dec 18, 2019
@SuperITMan
fix(stark-ui): add support for onClickCallback column properties in…
0139dda 
… Table component

Add `cellClicked` output in StarkTableColumnComponent.

ISSUES CLOSED: #1466
SuperITMan referenced this issue in SuperITMan/stark Dec 18, 2019
@SuperITMan
fix(stark-ui): add support for onClickCallback column properties in…
1121ca5 
… Table component

Add `cellClicked` output in StarkTableColumnComponent.

ISSUES CLOSED: #1466
SuperITMan referenced this issue in SuperITMan/stark Dec 18, 2019
@SuperITMan
fix(stark-ui): add support for onClickCallback column properties in…
c5e3847 
… Table component

Add `cellClicked` output in StarkTableColumnComponent.

ISSUES CLOSED: #1466
SuperITMan referenced this issue in SuperITMan/stark Jan 8, 2020
@SuperITMan
fix(stark-ui): add support for onClickCallback column properties in…
73e6b13 
… Table component

Add `cellClicked` output in StarkTableColumnComponent.

ISSUES CLOSED: #1466
@SuperITMan SuperITMan removed their assignment Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-ui type: bug
Projects
None yet
Milestone
10.0.0-rc.3
Development

Successfully merging a pull request may close this issue.

fix(stark-ui): add support for onClickCallback column properties in Table component SuperITMan/stark
1 participant
@SuperITMan