Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<input /> height too small #1374

Closed
carlo-nomes opened this issue Aug 1, 2019 · 0 comments · Fixed by #1382
Closed

<input /> height too small #1374

carlo-nomes opened this issue Aug 1, 2019 · 0 comments · Fixed by #1382
Assignees
@nicanac
Labels
comp: stark-ui type: bug
Milestone
10.0.0-rc.1

Comments

@carlo-nomes
Copy link
Collaborator

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

The default layout of inputs causes some letters (gj...) to be cut off at the bottom.
Screenshot 2019-08-01 at 13 59 25

Expected behavior

Correctly display value of inputs

Environment


Angular version: X.Y.Z
Stark version: X.Y.Z


Browser:
- [x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [x] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Platform:  MAC / WINDOWS

Others:
@carlo-nomes carlo-nomes changed the title <input /> height to small <input /> height too small Aug 1, 2019
@SuperITMan SuperITMan added this to the 10.0.0-rc.1 milestone Aug 6, 2019
@nicanac nicanac self-assigned this Aug 12, 2019
nicanac added a commit to nicanac/stark that referenced this issue Aug 13, 2019
@nicanac
fix(stark-ui): <input /> height too small
9fd99a6 
The default layout of inputs causes some letters (gj...) to be cut off at the bottom.

ISSUES CLOSED: NationalBankBelgium#1374
@nicanac nicanac mentioned this issue Aug 13, 2019
Merged
3 tasks
nicanac added a commit to nicanac/stark that referenced this issue Aug 13, 2019
@nicanac
fix(stark-ui): <input /> height too small
a23b222 
The default layout of inputs causes some letters (gj...) to be cut off at the bottom.

ISSUES CLOSED: NationalBankBelgium#1374
nicanac added a commit to nicanac/stark that referenced this issue Aug 13, 2019
@nicanac
fix(stark-ui): <input /> height too small
104b39b 
The default layout of inputs causes some letters (gj...) to be cut off at the bottom.

ISSUES CLOSED: NationalBankBelgium#1374
nicanac added a commit to nicanac/stark that referenced this issue Aug 13, 2019
@nicanac
fix(stark-ui): <input /> height too small
b1cbd08 
The default layout of inputs causes some letters (gj...) to be cut off at the bottom.

ISSUES CLOSED: NationalBankBelgium#1374
nicanac added a commit to nicanac/stark that referenced this issue Aug 13, 2019
@nicanac
fix(stark-ui): <input /> height too small
c22f2a0 
The default layout of inputs causes some letters (gj...) to be cut off at the bottom.

ISSUES CLOSED: NationalBankBelgium#1374
nicanac added a commit to nicanac/stark that referenced this issue Aug 13, 2019
@nicanac
fix(stark-ui): <input /> height too small
a245408 
The default layout of inputs causes some letters (gj...) to be cut off at the bottom.

ISSUES CLOSED: NationalBankBelgium#1374
nicanac added a commit to nicanac/stark that referenced this issue Aug 14, 2019
@nicanac
fix(stark-ui): reset line-height of input
7289ec7 
to avoid letters to be cut off at the bottom.

ISSUES CLOSED: NationalBankBelgium#1374
@SuperITMan SuperITMan mentioned this issue Jul 6, 2023
Closed
@SuperITMan SuperITMan mentioned this issue Oct 5, 2023
Closed
@SuperITMan SuperITMan mentioned this issue Feb 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicanac nicanac

Labels
comp: stark-ui type: bug
Projects
None yet
Milestone
10.0.0-rc.1
4 participants
@christophercr @SuperITMan @carlo-nomes @nicanac