Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: table - selection is not reset when data changes #1366

Closed
SuperITMan opened this issue Jul 30, 2019 · 0 comments · Fixed by #1377
Closed

ui: table - selection is not reset when data changes #1366

SuperITMan opened this issue Jul 30, 2019 · 0 comments · Fixed by #1377
Labels
comp: stark-ui type: bug
Milestone
10.0.0-rc.0

Comments

@SuperITMan
Copy link
Member

SuperITMan commented Jul 30, 2019 •
edited by christophercr
Loading

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

When data changes in table, the selection is not reset.

Expected behavior

When the data changes, the previous selection becomes invalid and should be reset.

What is the motivation / use case for changing the behavior?

Fix bug

Environment


Stark version: 10.0.0-beta.8
@SuperITMan SuperITMan added this to the 10.0.0-rc.0 milestone Jul 30, 2019
SuperITMan referenced this issue in SuperITMan/stark Jul 30, 2019
@SuperITMan
fix(stark-ui): table - when data changes, selection is now reset
c0d2f34 
ISSUES CLOSED: #1366
@SuperITMan SuperITMan mentioned this issue Jul 30, 2019
Closed
3 tasks
SuperITMan referenced this issue in SuperITMan/stark Jul 30, 2019
@SuperITMan
fix(stark-ui): table - when data changes, selection is now reset
2dd0521 
ISSUES CLOSED: #1366
SuperITMan referenced this issue in SuperITMan/stark Jul 31, 2019
@SuperITMan
fix(stark-ui): table - when data changes, selection is now reset
e4df160 
ISSUES CLOSED: #1366
SuperITMan referenced this issue in SuperITMan/stark Jul 31, 2019
@SuperITMan
feat(stark-ui): table - add selectedRows input
bd7cca6 
Adding selectedRows Input lets the developer controlling the selected
rows himself. Thanks to that, he can reset the selection if needed.

ISSUES CLOSED: #1366
SuperITMan referenced this issue in SuperITMan/stark Aug 7, 2019
@SuperITMan
feat(stark-ui): table - add support for NG CDK selection model.
66c069f 
ISSUES CLOSED: #1366

Disabled changeDetection strategy in Stark Table from 'OnPush' to 'Default' in order to
fix selection issues.
SuperITMan referenced this issue in SuperITMan/stark Aug 7, 2019
@SuperITMan
feat(stark-ui): table - add support for NG CDK selection model.
66d03a7 
ISSUES CLOSED: #1366

Disabled changeDetection strategy in Stark Table from 'OnPush' to 'Default' in order to
fix selection issues.
@SuperITMan SuperITMan mentioned this issue Aug 7, 2019
Merged
3 tasks
SuperITMan referenced this issue in SuperITMan/stark Aug 7, 2019
@SuperITMan
feat(stark-ui): table - add support for NG CDK selection model
c3b8d7f 
ISSUES CLOSED: #1366

Disabled changeDetection strategy in Stark Table from 'OnPush' to 'Default' in order to
fix selection issues.
SuperITMan referenced this issue in SuperITMan/stark Aug 7, 2019
@SuperITMan
feat(stark-ui): table - add support for NG CDK selection model
87c19e7 
ISSUES CLOSED: #1366

Disabled changeDetection strategy in Stark Table from 'OnPush' to 'Default' in order to
fix selection issues.
SuperITMan referenced this issue in SuperITMan/stark Aug 7, 2019
@SuperITMan
feat(stark-ui): table - add support for NG CDK selection model
f5cbee4 
ISSUES CLOSED: #1366

Disabled changeDetection strategy in Stark Table from 'OnPush' to 'Default' in order to
fix selection issues.
SuperITMan referenced this issue in SuperITMan/stark Aug 7, 2019
@SuperITMan
feat(stark-ui): table - add support for angular CDK selection model
e42aa14 
ISSUES CLOSED: #1366

Disabled changeDetection strategy in Stark Table from 'OnPush' to 'Default' in order to fix selection issues.
SuperITMan referenced this issue in SuperITMan/stark Aug 7, 2019
@SuperITMan
feat(stark-ui): table - add support for angular CDK selection model
e060da3 
ISSUES CLOSED: #1366

Disabled changeDetection strategy in Stark Table from 'OnPush' to 'Default' in order to fix selection issues.
SuperITMan referenced this issue in SuperITMan/stark Aug 7, 2019
@SuperITMan
feat(stark-ui): table - add support for angular CDK selection model
19c1731 
ISSUES CLOSED: #1366

Disabled changeDetection strategy in Stark Table from 'OnPush' to 'Default' in order to fix selection issues.
Deprecated 'multiSelect', 'rowsSelectable' Input and 'selectChanged'
Output in favor of the new 'selection' Input.
SuperITMan referenced this issue in SuperITMan/stark Aug 7, 2019
@SuperITMan
feat(stark-ui): table - add support for angular CDK selection model
a20da4f 
ISSUES CLOSED: #1366

Disabled changeDetection strategy in Stark Table from 'OnPush' to 'Default' in order to fix selection issues.
Deprecated 'multiSelect', 'rowsSelectable' Input and 'selectChanged'
Output in favor of the new 'selection' Input.
@SuperITMan SuperITMan removed their assignment Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-ui type: bug
Projects
None yet
Milestone
10.0.0-rc.0
1 participant
@SuperITMan