Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: date-picker - translate placeholder internally as before #1204

Closed
SuperITMan opened this issue Mar 19, 2019 · 0 comments · Fixed by #1208
Closed

ui: date-picker - translate placeholder internally as before #1204

SuperITMan opened this issue Mar 19, 2019 · 0 comments · Fixed by #1208

Comments

@SuperITMan
Copy link
Member

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

Currently, the placeholder has to be translated by the the component which is calling stark-date-picker --> <stark-date-picker [placeholder]="'MY_TRANSLATION_KEY' | translate".

Previously, it was handled by the date-picker itself.

Expected behavior

We should handle the translation again in the date-picker component.

What is the motivation / use case for changing the behavior?

Improve the developer's life 😊

@SuperITMan SuperITMan added this to the 10.0.0-beta.7 milestone Mar 19, 2019
SuperITMan referenced this issue in SuperITMan/stark Mar 20, 2019
SuperITMan referenced this issue in SuperITMan/stark Mar 20, 2019
SuperITMan referenced this issue in SuperITMan/stark Mar 20, 2019
SuperITMan referenced this issue in SuperITMan/stark Mar 20, 2019
SuperITMan referenced this issue in SuperITMan/stark Mar 21, 2019
SuperITMan referenced this issue in SuperITMan/stark Mar 21, 2019
SuperITMan referenced this issue in SuperITMan/stark Mar 21, 2019
@SuperITMan SuperITMan removed their assignment Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants