Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Viewport issues #1169

Closed
carlo-nomes opened this issue Mar 5, 2019 · 0 comments
Closed

ui: Viewport issues #1169

carlo-nomes opened this issue Mar 5, 2019 · 0 comments
Labels
comp: stark-ui must type: bug
Milestone
10.0.0-beta.6

Comments

@carlo-nomes
Copy link
Collaborator

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

When the site content is smaller than the viewport several issues occur. (footer floats, menu does not go to bottom, etc.)

Expected behavior

When the screen is not filled the components should be displayed correctly.
The entire viewport is used by the application.
@carlo-nomes carlo-nomes self-assigned this Mar 5, 2019
@SuperITMan SuperITMan added this to the 10.0.0-beta.6 milestone Mar 5, 2019
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 5, 2019
@carlo-nomes
fix(stark-ui): update some component styling to fix bugs
764ee3b 
  - fix footer overflow
  - fix footer hovering above bottom of screen
  - removed unused redundant DOM from `app.component.html` (showcase / starter)

ISSUES CLOSED: NationalBankBelgium#1169

BREAKING CHANGES:

  - `stark-app-sidenav-content` should not be applied to a wrapper element (`div`) anymore. Replace it with a `ng-container`.
  This ensures the footer is always at the bottom. (see Starter for an example)
@carlo-nomes carlo-nomes mentioned this issue Mar 5, 2019
Merged
3 tasks
@christophercr christophercr changed the title Fix viewport issues ui: Viewport issues Mar 6, 2019
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 6, 2019
@carlo-nomes
fix(stark-ui): update some component styling to fix bugs
5b980f0 
  - fix footer overflow
  - fix footer hovering above bottom of screen
  - removed unused redundant DOM from `app.component.html` (showcase / starter)

ISSUES CLOSED: NationalBankBelgium#1169

BREAKING CHANGES:

  - `stark-app-sidenav-content` should not be applied to a wrapper element (`div`) anymore. Replace it with a `ng-container`.
  This ensures the footer is always at the bottom. (see Starter for an example)
@carlo-nomes carlo-nomes mentioned this issue Mar 6, 2019
Open
carlo-nomes added a commit to carlo-nomes/stark that referenced this issue Mar 6, 2019
@carlo-nomes
fix(stark-ui): update some component styling to fix bugs
863f29c 
  - fix footer overflow
  - fix footer hovering above bottom of screen
  - removed unused redundant DOM from `app.component.html` (showcase / starter)

ISSUES CLOSED: NationalBankBelgium#1169

BREAKING CHANGES:

  - `stark-app-sidenav-content` should not be applied to a wrapper element (`div`) anymore. Replace it with a `ng-container`.
  This ensures the footer is always at the bottom. (see Starter for an example)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-ui must type: bug
Projects
None yet
Milestone
10.0.0-beta.6
Development

No branches or pull requests
3 participants
@christophercr @SuperITMan @carlo-nomes