Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: date-picker - add support for Reactive Forms #1146

Closed
christophercr opened this issue Feb 22, 2019 · 0 comments · Fixed by #1178
Closed

ui: date-picker - add support for Reactive Forms #1146

christophercr opened this issue Feb 22, 2019 · 0 comments · Fixed by #1178
Labels
comp: stark-ui must type: enhancement type: feature
Milestone
10.0.0-beta.6

Comments

@christophercr
Copy link
Collaborator

christophercr commented Feb 22, 2019 •
edited
Loading

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[X] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

Currently the Stark date-picker works only with the legacy "model driven" approach which means that it relies in the ngModel. However, since Angular2+ apart from these type of forms there are the Reactive Forms, which are more powerful than model driven forms.

Expected behavior

The Stark date-picker should work with Reactive Forms so the developer can define the form control to be bound to the picker and set/read the value himself.

What is the motivation / use case for changing the behavior?

Provide an easy to use, flexible and yet powerful date-picker component.
@christophercr christophercr added this to the 10.0.0-beta.5 milestone Feb 22, 2019
@SuperITMan SuperITMan self-assigned this Mar 1, 2019
SuperITMan referenced this issue in SuperITMan/stark Mar 1, 2019
@SuperITMan
feat(stark-ui): add support for reactive forms in date picker component
326273b 
ISSUES CLOSED: #1146
SuperITMan referenced this issue in SuperITMan/stark Mar 5, 2019
@SuperITMan
feat(stark-ui): add support for reactive forms in date picker component
97dd588 
ISSUES CLOSED: #1146
SuperITMan referenced this issue in SuperITMan/stark Mar 5, 2019
@SuperITMan
feat(stark-ui): add support for reactive forms in date picker component
2dbc5a9 
ISSUES CLOSED: #1146
SuperITMan referenced this issue in SuperITMan/stark Mar 7, 2019
@SuperITMan
feat(stark-ui): date-picker - add support for ControlValueAccessor an…
53bc6b6 
…d Validator

ISSUES CLOSED: #1146

BREAKING CHANGE: stark-date-picker now integrates ControlValueAccessor and Validator:

  - The following Input have been changed:
      - **date** is now **value**
      - **isDisabled** is now **disabled**
  - The output **dateChanged** is now **dateChange**
  - **dateInput** Output has been added and now the date-picker Input/Output are
    similar to the ones of MatDatepicker component
SuperITMan referenced this issue in SuperITMan/stark Mar 7, 2019
@SuperITMan
feat(stark-ui): date-picker - add support for ControlValueAccessor an…
d150546 
…d Validator

ISSUES CLOSED: #1146

BREAKING CHANGE: stark-date-picker now integrates ControlValueAccessor and Validator:

  - The following Input have been changed:
      - **date** is now **value**
      - **isDisabled** is now **disabled**
  - The output **dateChanged** is now **dateChange**
  - **dateInput** Output has been added and now the date-picker Input/Output are
    similar to the ones of MatDatepicker component
@SuperITMan SuperITMan mentioned this issue Mar 7, 2019
Merged
3 tasks
SuperITMan referenced this issue in SuperITMan/stark Mar 7, 2019
@SuperITMan
feat(stark-ui): date-picker - add support for ControlValueAccessor an…
c0dd4c3 
…d Validator

ISSUES CLOSED: #1146

BREAKING CHANGE: stark-date-picker now integrates ControlValueAccessor and Validator:

  - The following Input have been changed:
      - **date** is now **value**
      - **isDisabled** is now **disabled**
  - The output **dateChanged** is now **dateChange**
  - **dateInput** Output has been added and now the date-picker Input/Output are
    similar to the ones of MatDatepicker component
SuperITMan referenced this issue in SuperITMan/stark Mar 14, 2019
@SuperITMan
feat(stark-ui): date-picker - add support for ControlValueAccessor, M…
dcf5e27 
…atFormFieldControl, Validator and starkTimestampMask directive

ISSUES CLOSED: #1146, #1180

BREAKING CHANGE: stark-date-picker now integrates ControlValueAccessor and Validator:

  - The following Input have been changed:
      - **date** is now **value**
      - **isDisabled** is now **disabled**
  - The output **dateChanged** is now **dateChange**
  - **dateInput** Output has been added and now the date-picker Input/Output are
    similar to the ones of MatDatepicker component
SuperITMan referenced this issue in SuperITMan/stark Mar 14, 2019
@SuperITMan
feat(stark-ui): date-picker - add support for ControlValueAccessor, M…
cebbd64 
…atFormFieldControl, Validator and starkTimestampMask directive

ISSUES CLOSED: #1146, #1180

BREAKING CHANGE: stark-date-picker now integrates ControlValueAccessor and Validator:

  - The following Input have been changed:
      - **date** is now **value**
      - **maxDate** is now **max**
      - **minDate** is now **min**
      - **label** is now **placeholder**
      - **isDisabled** is now **disabled**
  - The output **dateChanged** is now **dateChange**
  - **dateInput** Output has been added and now the date-picker Input/Output are
    similar to the ones of MatDatepicker component
  - We respect now the Constraint validation standards. See: https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/HTML5/Constraint_validation#Validation-related_attributes
SuperITMan referenced this issue in SuperITMan/stark Mar 14, 2019
@SuperITMan
feat(stark-ui): date-picker - add support for ControlValueAccessor, M…
4f54ca8 
…atFormFieldControl, Validator and starkTimestampMask directive

ISSUES CLOSED: #1146, #1180

BREAKING CHANGE: stark-date-picker now integrates ControlValueAccessor and Validator:

  - The following Input have been changed:
      - **date** is now **value**
      - **maxDate** is now **max**
      - **minDate** is now **min**
      - **label** is now **placeholder**
      - **isDisabled** is now **disabled**
  - The output **dateChanged** is now **dateChange**
  - **dateInput** Output has been added and now the date-picker Input/Output are
    similar to the ones of MatDatepicker component
  - We respect now the Constraint validation standards. See: https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/HTML5/Constraint_validation#Validation-related_attributes
SuperITMan referenced this issue in SuperITMan/stark Mar 14, 2019
@SuperITMan
feat(stark-ui): date-picker - add support for ControlValueAccessor, M…
b3ec254 
…atFormFieldControl, Validator and starkTimestampMask directive

ISSUES CLOSED: #1146, #1180

BREAKING CHANGE: stark-date-picker now integrates ControlValueAccessor and Validator:

  - The following Input have been changed:
      - **date** is now **value**
      - **maxDate** is now **max**
      - **minDate** is now **min**
      - **label** is now **placeholder**
      - **isDisabled** is now **disabled**
  - The output **dateChanged** is now **dateChange**
  - **dateInput** Output has been added and now the date-picker Input/Output are
    similar to the ones of MatDatepicker component
  - We respect now the Constraint validation standards. See: https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/HTML5/Constraint_validation#Validation-related_attributes
SuperITMan referenced this issue in SuperITMan/stark Mar 14, 2019
@SuperITMan
feat(stark-ui): date-picker - add support for ControlValueAccessor, M…
8d6ac8c 
…atFormFieldControl, Validator and starkTimestampMask directive

ISSUES CLOSED: #1146, #1180

BREAKING CHANGE: stark-date-picker now integrates ControlValueAccessor and Validator:

  - The following Input have been changed:
      - **date** is now **value**
      - **maxDate** is now **max**
      - **minDate** is now **min**
      - **label** is now **placeholder**
      - **isDisabled** is now **disabled**
  - The output **dateChanged** is now **dateChange**
  - **dateInput** Output has been added and now the date-picker Input/Output are
    similar to the ones of MatDatepicker component
  - We respect now the Constraint validation standards. See: https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/HTML5/Constraint_validation#Validation-related_attributes
SuperITMan referenced this issue in SuperITMan/stark Mar 14, 2019
@SuperITMan
feat(stark-ui): date-picker - add support for ControlValueAccessor, M…
c46f822 
…atFormFieldControl, Validator and starkTimestampMask directive

ISSUES CLOSED: #1146, #1180

BREAKING CHANGE: stark-date-picker now integrates ControlValueAccessor and Validator:

  - The following Input have been changed:
      - **date** is now **value**
      - **maxDate** is now **max**
      - **minDate** is now **min**
      - **label** is now **placeholder**
      - **isDisabled** is now **disabled**
  - The output **dateChanged** is now **dateChange**
  - **dateInput** Output has been added and now the date-picker Input/Output are
    similar to the ones of MatDatepicker component
  - We respect now the Constraint validation standards. See: https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/HTML5/Constraint_validation#Validation-related_attributes
SuperITMan referenced this issue in SuperITMan/stark Mar 15, 2019
@SuperITMan
feat(stark-ui): date-picker - add support for ControlValueAccessor, M…
33fdd2c 
…atFormFieldControl, Validator and starkTimestampMask directive

ISSUES CLOSED: #1146, #1180

BREAKING CHANGE: stark-date-picker now integrates ControlValueAccessor and Validator:

  - The following Input have been changed:
      - **date** is now **value**
      - **maxDate** is now **max**
      - **minDate** is now **min**
      - **label** is now **placeholder**
      - **isDisabled** is now **disabled**
  - The output **dateChanged** is now **dateChange**
  - **dateInput** Output has been added and now the date-picker Input/Output are
    similar to the ones of MatDatepicker component
  - We respect now the Constraint validation standards. See: https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/HTML5/Constraint_validation#Validation-related_attributes
SuperITMan referenced this issue in SuperITMan/stark Mar 15, 2019
@SuperITMan
feat(stark-ui): date-picker - add support for ControlValueAccessor, M…
9435f3a 
…atFormFieldControl, Validator and starkTimestampMask directive

ISSUES CLOSED: #1146, #1180

BREAKING CHANGE: stark-date-picker now integrates ControlValueAccessor and Validator:

  - The following Input have been changed:
      - **date** is now **value**
      - **maxDate** is now **max**
      - **minDate** is now **min**
      - **label** is now **placeholder**
      - **isDisabled** is now **disabled**
  - The output **dateChanged** is now **dateChange**
  - **dateInput** Output has been added and now the date-picker Input/Output are
    similar to the ones of MatDatepicker component
  - We respect now the Constraint validation standards. See: https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/HTML5/Constraint_validation#Validation-related_attributes
SuperITMan referenced this issue in SuperITMan/stark Mar 15, 2019
@SuperITMan
feat(stark-ui): date-picker - add support for ControlValueAccessor, M…
22da592 
…atFormFieldControl, Validator and starkTimestampMask directive

ISSUES CLOSED: #1146, #1180

BREAKING CHANGE: stark-date-picker now integrates ControlValueAccessor and Validator:

  - The following Input have been changed:
      - **date** is now **value**
      - **maxDate** is now **max**
      - **minDate** is now **min**
      - **label** is now **placeholder**
      - **isDisabled** is now **disabled**
  - The output **dateChanged** is now **dateChange**
  - **dateInput** Output has been added and now the date-picker Input/Output are
    similar to the ones of MatDatepicker component
  - We respect now the Constraint validation standards. See: https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/HTML5/Constraint_validation#Validation-related_attributes
SuperITMan referenced this issue in SuperITMan/stark Mar 15, 2019
@SuperITMan
feat(stark-ui): date-picker - add support for ControlValueAccessor, M…
e9749a5 
…atFormFieldControl, Validator and starkTimestampMask directive

  * add `dateMask` input binding to date-picker. It allows to use
timestampMask directive.
  * add `required` input binding.

ISSUES CLOSED: #1146

BREAKING CHANGE: stark-date-picker now integrates ControlValueAccessor and Validator:

  - The following Input have been changed:
      - **date** is now **value**
      - **maxDate** is now **max**
      - **minDate** is now **min**
      - **label** is now **placeholder**
      - **isDisabled** is now **disabled**
  - The output **dateChanged** is now **dateChange**
  - **dateInput** Output has been added and now the date-picker Input/Output are
    similar to the ones of MatDatepicker component
  - We respect now the Constraint validation standards. See: https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/HTML5/Constraint_validation#Validation-related_attributes
SuperITMan referenced this issue in SuperITMan/stark Mar 18, 2019
@SuperITMan @ageorges-nbb
feat(stark-ui): date-picker - add support for ControlValueAccessor, M…
81dcd18 
…atFormFieldControl, Validator and starkTimestampMask directive

  * add `dateMask` input binding to date-picker. It allows to use
timestampMask directive.
  * add `required` input binding.

ISSUES CLOSED: #1146

BREAKING CHANGE: stark-date-picker now integrates ControlValueAccessor and Validator:

  - The following Input have been changed:
      - **date** is now **value**
      - **maxDate** is now **max**
      - **minDate** is now **min**
      - **label** is now **placeholder** (the date-picker does not
      translate the placeholder anymore, it has to be done by the
      developer when passing the value --> `[placeholder]="'MY_TRANSLATION_KEY' | translate"`)
      - **isDisabled** is now **disabled**
  - The output **dateChanged** is now **dateChange**
  - **dateInput** Output has been added and now the date-picker Input/Output are
    similar to the ones of MatDatepicker component
  - We respect now the Constraint validation standards. See: https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/HTML5/Constraint_validation#Validation-related_attributes
@christophercr christophercr changed the title ui: date-pickers - add support for Reactive Forms ui: date-picker - add support for Reactive Forms Mar 18, 2019
@SuperITMan SuperITMan removed their assignment Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-ui must type: enhancement type: feature
Projects
None yet
Milestone
10.0.0-beta.6
2 participants
@christophercr @SuperITMan