Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bundles design #114

Closed
dsebastien opened this issue Mar 2, 2018 · 4 comments
Closed

build: bundles design #114

dsebastien opened this issue Mar 2, 2018 · 4 comments
Labels
comp: stark-build Stark Build effort: hours must type: discussion / RFC
Milestone
10.0.0-beta.5

Comments

@dsebastien
Copy link
Contributor

Currently we've started from the most recent Angular Starter version. In the webpack common config, two entry points are defined: main & polyfills
-> https://github.com/gdi2290/angular-starter/blob/master/config/webpack.common.js

In our Stark "v1", we had more than that:

  • polyfills: src/polyfills.ts
  • vendor-styles: src/vendor-styles.ts
  • main-styles: src/main-styles.ts
  • vendor: src/vendor.ts
  • main: src/main.ts

This was useful for caching. Now indeed things may be changing with AOT, lazy loading, ...

So we need to decide what to do with our bundles
@dsebastien dsebastien added this to the must milestone Mar 2, 2018
@dsebastien dsebastien mentioned this issue Mar 5, 2018
Closed
3 tasks
@dsebastien dsebastien added the must label Mar 5, 2018
@dsebastien dsebastien modified the milestones: must, 10.0.0-alpha.1 Mar 5, 2018
@dsebastien
Copy link
Contributor Author

  • Document lazy loading of modules
  • Do we need main-style entry point?
  • Do we need vendor and vendor-style entry point?

@ncedric ncedric self-assigned this Mar 12, 2018
@dsebastien dsebastien modified the milestones: 10.0.0-alpha.1, sprint 1 Mar 19, 2018
@dsebastien dsebastien added the P1 label Apr 24, 2018
@dsebastien dsebastien modified the milestones: sprint 1, 10.0.0-alpha.4 May 8, 2018
@SuperITMan SuperITMan self-assigned this Aug 23, 2018
@christophercr christophercr removed this from the 10.0.0-alpha.5 milestone Sep 6, 2018
@christophercr christophercr added this to the 10.0.0-beta.1 milestone Sep 26, 2018
@SuperITMan SuperITMan mentioned this issue Nov 26, 2018
Closed
@christophercr christophercr removed this from the 10.0.0-beta.3 milestone Jan 22, 2019
@christophercr christophercr mentioned this issue Jan 25, 2019
Merged
3 tasks
@christophercr
Copy link
Collaborator

This will be tackled together with #883

christophercr referenced this issue in christophercr/stark Feb 26, 2019
@christophercr
feat(stark-build): implement integration with Angular CLI via @angula…
9a26c00 
…r-builders

ISSUES CLOSED: #883, #146, #114

BREAKING CHANGE: stark-build now integrates with Angular CLI:

   - **stark-build:** now provides partial Webpack configurations to override default configuration from Angular CLI. The application's `angular.json` file must be adapted to use this partial configs from stark-build via [@angular-builders](https://github.com/meltedspark/angular-builders). See [Stark-Build: Ng CLI Customizations](./docs/stark-build/NG_CLI_BUILD_CUSTOMIZATIONS.md)
   - **stark-core:** the application's `angular.json` file must be adapted to add the assets from stark-core to be copied to the application's `assets` folder. See [Stark-Core: Getting Started](./docs/stark-core/GETTING_STARTED.md#assets)
   - **stark-ui:** the application's `angular.json` file must be adapted to add the assets from stark-ui to be copied to the application's `assets` folder. See [Stark-UI: Getting Started](./docs/stark-ui/GETTING_STARTED.md#assets)
@christophercr christophercr mentioned this issue Feb 26, 2019
Merged
3 tasks
@christophercr
Copy link
Collaborator

Solved in #1148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-build Stark Build effort: hours must type: discussion / RFC
Projects
None yet
Milestone
10.0.0-beta.5
Development

No branches or pull requests
4 participants
@dsebastien @christophercr @SuperITMan @ncedric