Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Generic Search - Search form is not reset when click on reset button #1125

Closed
SuperITMan opened this issue Feb 7, 2019 · 2 comments · Fixed by #1161
Closed

ui: Generic Search - Search form is not reset when click on reset button #1125

SuperITMan opened this issue Feb 7, 2019 · 2 comments · Fixed by #1161
Labels
comp: stark-ui type: bug
Milestone
10.0.0-beta.5

Comments

@SuperITMan
Copy link
Member

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#got-a-question-or-problem

Current behavior

When the user clicks on the reset button in the generic search component, the search form is not resetted.

Expected behavior

When click on reset, the search form should be resetted.

Environment


Angular version: 7.x.x
Stark version: 10.0.0-beta.3
@SuperITMan SuperITMan added this to the 10.0.0-beta.4 milestone Feb 7, 2019
@SuperITMan
Copy link
Member Author

done in 10.0.0-beta.4

@christophercr
Copy link
Collaborator

Re-opening as this issue has not been fixed. See https://stark.nbb.be/showcase/10.0.0-beta.4/demo-ui/generic-search

@christophercr christophercr reopened this Feb 28, 2019
@christophercr christophercr self-assigned this Feb 28, 2019
christophercr added a commit to christophercr/stark that referenced this issue Feb 28, 2019
@christophercr
fix(stark-ui): add methods to create/reset the search form in the Gen…
f95d7c7 
…eric Search. Fix the Generic Search demo page in Showcase.

ISSUES CLOSED: NationalBankBelgium#1125

BREAKING CHANGE: new methods added to `StarkSearchFormComponent` interface:

   - createSearchForm: method that should contain the necessary logic to create
   the FormGroup to be bound to the search form.
   - resetSearchForm: method that should contain the necessary logic to
   reset the FormGroup bound to the search form.
@christophercr christophercr mentioned this issue Feb 28, 2019
Merged
3 tasks
christophercr added a commit to christophercr/stark that referenced this issue Feb 28, 2019
@christophercr
fix(stark-ui): add methods to create/reset the search form in the Gen…
128d8bf 
…eric Search. Fix the Generic Search demo page in Showcase.

ISSUES CLOSED: NationalBankBelgium#1125

BREAKING CHANGE: new methods added to `StarkSearchFormComponent` interface:

   - **createSearchForm:** method that should contain the necessary logic to create
   the FormGroup to be bound to the search form.
   - **resetSearchForm:** method that should contain the necessary logic to
   reset the FormGroup bound to the search form.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp: stark-ui type: bug
Projects
None yet
Milestone
10.0.0-beta.5
2 participants
@christophercr @SuperITMan